Issue 484003: Revert 34195 - Make sure the 'use_system_*' variables are actually visible in...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 484003: Revert 34195 - Make sure the 'use_system_*' variables are actually visible in... (Closed)

Created:
11 years ago by John Grabowski

Modified:
9 years, 6 months ago

Reviewers:
mmoss

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 34195 - Make sure the 'use_system_*' variables are actually visible in the relevant gyp files. BUG=29738 Review URL: http://codereview.chromium.org/479005 TBR=mmoss@google.com Example choke: http://build.chromium.org/buildbot/waterfall/builders/Linux%20Perf/builds/4382/steps/compile/logs/stdio Compiling /b/slave/chromium-rel-linux-hardy/build/src/sconsbuild/Release/obj/chrome/unit_tests/common/bzip2_unittest.o /b/slave/chromium-rel-linux-hardy/build/src/chrome/common/bzip2_unittest.cc:6:19: error: bzlib.h: No such file or directory Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34213

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -52 lines)			Patch
M	build/common.gypi	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	build/install-build-deps.sh	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	build/linux/system.gyp	View	1 chunk	+3 lines, -11 lines	0 comments	Download
M	third_party/bzip2/bzip2.gyp	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	third_party/libjpeg/libjpeg.gyp	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	third_party/libpng/libpng.gyp	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	third_party/libxslt/libxslt.gyp	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	third_party/zlib/zlib.gyp	View	1 chunk	+1 line, -8 lines	0 comments	Download

Total messages: 1 (0 generated)