Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 479005: Make sure the 'use_system_*' variables are actually visible in the relevant gyp files. (Closed)

Created:
11 years ago by Michael Moss
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Make sure the 'use_system_*' variables are actually visible in the relevant gyp files. BUG=29738

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -25 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -14 lines 0 comments Download
M build/install-build-deps.sh View 1 chunk +3 lines, -3 lines 0 comments Download
M build/linux/system.gyp View 1 chunk +11 lines, -3 lines 0 comments Download
M third_party/bzip2/bzip2.gyp View 1 chunk +8 lines, -1 line 0 comments Download
M third_party/libjpeg/libjpeg.gyp View 1 chunk +8 lines, -1 line 0 comments Download
M third_party/libpng/libpng.gyp View 1 chunk +8 lines, -1 line 0 comments Download
M third_party/libxslt/libxslt.gyp View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/zlib/zlib.gyp View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Moss
11 years ago (2009-12-09 20:45:09 UTC) #1
agl
11 years ago (2009-12-09 21:09:30 UTC) #2
LGTM. Sorry for fucking it up the first time!

Powered by Google App Engine
This is Rietveld 408576698