Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2080)

Unified Diff: chrome/browser/resources/options/personal_options.html

Issue 4821003: DOMUI: Turn the google dashboard link into a real link and fix the behavior of (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/personal_options.html
diff --git a/chrome/browser/resources/options/personal_options.html b/chrome/browser/resources/options/personal_options.html
index 5988915d5fb77dd8ece624d64bca70d47e76b7b7..56053479b0e12d4f82c97052081407d7e0d5a3f3 100644
--- a/chrome/browser/resources/options/personal_options.html
+++ b/chrome/browser/resources/options/personal_options.html
@@ -26,8 +26,8 @@
<button id="start-stop-sync"></button>
<button id="customize-sync""></button>
</div>
- <button id="privacy-dashboard-link" class="link-button"
- i18n-content="privacy_dashboard_link"></button>
+ <a href="https://www.google.com/dashboard" id="privacy-dashboard-link"
+ i18n-content="privacy_dashboard_link" target="_blank"></a>
</div>
</section>
<section>
@@ -74,7 +74,8 @@
i18n-content="themes_GTK_button"></button>
<button id="themes_set_classic"
i18n-content="themes_set_classic"></button>
- <a i18n-content="themes_gallery" id="themes-gallery" href="#"></a>
+ <a id="themes-gallery" i18n-content="themes_gallery"
+ i18n-values="href:themes_gallery_url" target="_blank"></a>
</div>
<label class="radio">
<input name="decorations_radio"
@@ -96,7 +97,8 @@
<h3 i18n-content="themes"></h3>
<div>
<button id="themes_reset" i18n-content="themes_reset"></button>
- <a i18n-content="themes_gallery" id="themes-gallery" href="#"></a>
+ <a id="themes-gallery" i18n-content="themes_gallery"
+ i18n-values="href:themes_gallery_url" target="_blank"></a>
</div>
</section>
</if>
« no previous file with comments | « chrome/browser/dom_ui/options/personal_options_handler.cc ('k') | chrome/browser/resources/options/personal_options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698