Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: chrome/browser/dom_ui/options/personal_options_handler.cc

Issue 4821003: DOMUI: Turn the google dashboard link into a real link and fix the behavior of (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/dom_ui/options/personal_options_handler.cc
diff --git a/chrome/browser/dom_ui/options/personal_options_handler.cc b/chrome/browser/dom_ui/options/personal_options_handler.cc
index 4c776b9af030e6f7371a9e2d631edc8d3fc735ae..8eb86e7555ad06e3ba458114531ccd5ae61b965b 100644
--- a/chrome/browser/dom_ui/options/personal_options_handler.cc
+++ b/chrome/browser/dom_ui/options/personal_options_handler.cc
@@ -89,6 +89,11 @@ void PersonalOptionsHandler::GetLocalizedValues(
localized_strings->SetString("import_data",
l10n_util::GetStringUTF16(IDS_OPTIONS_IMPORT_DATA_BUTTON));
+ localized_strings->SetString("themes_gallery",
+ l10n_util::GetStringUTF16(IDS_THEMES_GALLERY_BUTTON));
+ localized_strings->SetString("themes_gallery_url",
+ l10n_util::GetStringUTF16(IDS_THEMES_GALLERY_URL));
+
#if defined(TOOLKIT_GTK)
localized_strings->SetString("appearance",
l10n_util::GetStringUTF16(IDS_APPEARANCE_GROUP_NAME));
@@ -100,15 +105,11 @@ void PersonalOptionsHandler::GetLocalizedValues(
l10n_util::GetStringUTF16(IDS_SHOW_WINDOW_DECORATIONS_RADIO));
localized_strings->SetString("hideWindow_decorations_radio",
l10n_util::GetStringUTF16(IDS_HIDE_WINDOW_DECORATIONS_RADIO));
- localized_strings->SetString("themes_gallery",
- l10n_util::GetStringUTF16(IDS_THEMES_GALLERY_BUTTON));
#else
localized_strings->SetString("themes",
l10n_util::GetStringUTF16(IDS_THEMES_GROUP_NAME));
localized_strings->SetString("themes_reset",
l10n_util::GetStringUTF16(IDS_THEMES_RESET_BUTTON));
- localized_strings->SetString("themes_gallery",
- l10n_util::GetStringUTF16(IDS_THEMES_GALLERY_BUTTON));
localized_strings->SetString("themes_default",
l10n_util::GetStringUTF16(IDS_THEMES_DEFAULT_THEME_LABEL));
#endif
@@ -120,15 +121,8 @@ void PersonalOptionsHandler::RegisterMessages() {
"showSyncLoginDialog",
NewCallback(this, &PersonalOptionsHandler::ShowSyncLoginDialog));
dom_ui_->RegisterMessageCallback(
- "openPrivacyDashboardTabAndActivate",
- NewCallback(this,
- &PersonalOptionsHandler::OpenPrivacyDashboardTabAndActivate));
- dom_ui_->RegisterMessageCallback(
"themesReset",
NewCallback(this, &PersonalOptionsHandler::ThemesReset));
- dom_ui_->RegisterMessageCallback(
- "themesGallery",
- NewCallback(this, &PersonalOptionsHandler::ThemesGallery));
#if defined(TOOLKIT_GTK)
dom_ui_->RegisterMessageCallback(
"themesSetGTK",
@@ -279,21 +273,11 @@ void PersonalOptionsHandler::ShowSyncLoginDialog(const ListValue* args) {
ProfileSyncService::SyncEvent(ProfileSyncService::START_FROM_OPTIONS);
}
-void PersonalOptionsHandler::OpenPrivacyDashboardTabAndActivate(
- const ListValue* args) {
- BrowserList::GetLastActive()->OpenPrivacyDashboardTabAndActivate();
-}
-
void PersonalOptionsHandler::ThemesReset(const ListValue* args) {
UserMetricsRecordAction(UserMetricsAction("Options_ThemesReset"));
dom_ui_->GetProfile()->ClearTheme();
}
-void PersonalOptionsHandler::ThemesGallery(const ListValue* args) {
- UserMetricsRecordAction(UserMetricsAction("Options_ThemesGallery"));
- BrowserList::GetLastActive()->OpenThemeGalleryTabAndActivate();
-}
-
#if defined(TOOLKIT_GTK)
void PersonalOptionsHandler::ThemesSetGTK(const ListValue* args) {
UserMetricsRecordAction(UserMetricsAction("Options_GtkThemeSet"));
« no previous file with comments | « chrome/browser/dom_ui/options/personal_options_handler.h ('k') | chrome/browser/resources/options/personal_options.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698