src/flags.cc - Issue 48126: Fixing potentially problematic usage of OS::StrDup that caused some strings t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/flags.cc

Issue 48126: Fixing potentially problematic usage of OS::StrDup that caused some strings t... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/flags.cc

===================================================================

--- src/flags.cc (revision 1525)

+++ src/flags.cc (working copy)

@@ -248,7 +248,7 @@

args->Add(buffer.ToCString().Detach());

JSArguments jsargs = *args_flag->args_variable();

for (int j = 0; j < jsargs.argc(); j++) {

- args->Add(OS::StrDup(jsargs[j]));

+ args->Add(StrDup(jsargs[j]));

}

return args;

« no previous file with comments | « src/d8-debug.cc ('k') | no next file » | no next file with comments »