Fixing potentially problematic usage of OS::StrDup that caused some strings t...

src/flags.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 230 matching lines @@
       }
     }
   }
   if (args_flag != NULL) {
     HeapStringAllocator string_allocator;
     StringStream buffer(&string_allocator);
     buffer.Add("--%s", args_flag->name());
     args->Add(buffer.ToCString().Detach());
     JSArguments jsargs = *args_flag->args_variable();
     for (int j = 0; j < jsargs.argc(); j++) {
-      args->Add(OS::StrDup(jsargs[j]));
+      args->Add(StrDup(jsargs[j]));
     }
   }
   return args;
 }
 
 
 // Helper function to parse flags: Takes an argument arg and splits it into
 // a flag name and flag value (or NULL if they are missing). is_bool is set
 // if the arg started with "-no" or "--no". The buffer may be used to NUL-
 // terminate the name, it must be large enough to hold any possible name.
@@ skipping 278 matching lines @@
 const char** JSArguments::argv() { return argv_; }
 const char*& JSArguments::operator[](int idx) { return argv_[idx]; }
 JSArguments& JSArguments::operator=(JSArguments args) {
     argc_ = args.argc_;
     argv_ = args.argv_;
     return *this;
 }
 
 
 } }  // namespace v8::internal