Issue 48126: Fixing potentially problematic usage of OS::StrDup that caused some strings t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 48126: Fixing potentially problematic usage of OS::StrDup that caused some strings t... (Closed)

Created:
11 years, 9 months ago by olehougaard

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fixing potentially problematic usage of OS::StrDup that caused some strings to be allocated with malloc() but freed with delete[]. Committed: http://code.google.com/p/v8/source/detail?r=1531

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/d8-debug.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/flags.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

11 years, 9 months ago (2009-03-18 11:54:52 UTC) #2

LGTM!

On 2009/03/18 11:51:48, olehougaard wrote:
>

Expand Messages | Collapse Messages