Issue 48112: Disk cache: First implementation of TrimDeleted() and a few...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 48112: Disk cache: First implementation of TrimDeleted() and a few... (Closed)

Created:
11 years, 9 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disk cache: First implementation of TrimDeleted() and a few other fixes related to the new eviction code. As before, almost everything is disabled by default. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11995

Patch Set 1 #

Total comments: 2

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -10 lines)			Patch
M	net/disk_cache/backend_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/disk_cache/disk_cache.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/disk_cache/entry_impl.cc	View	2 chunks	+10 lines, -4 lines	0 comments	Download
M	net/disk_cache/eviction.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/disk_cache/eviction.cc	View	4 chunks	+55 lines, -4 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

LGTM http://codereview.chromium.org/48112/diff/1/6 File net/disk_cache/eviction.cc (right): http://codereview.chromium.org/48112/diff/1/6#newcode216 Line 216: !NodeIsOldEnough(next[Rankings::HIGH_USE].get(), 0)) the zero here, it should ...

11 years, 9 months ago (2009-03-18 17:17:35 UTC) #2

rvargas (doing something else)

11 years, 9 months ago (2009-03-18 17:32:13 UTC) #3

Thanks.

http://codereview.chromium.org/48112/diff/1/6
File net/disk_cache/eviction.cc (right):

http://codereview.chromium.org/48112/diff/1/6#newcode216
Line 216: !NodeIsOldEnough(next[Rankings::HIGH_USE].get(), 0))
On 2009/03/18 17:17:35, Nicolas Sylvain wrote:
> the zero here, it should not be "list" ?
no 'cause NodeIsOldEnough(next[2], 2) was already tested to be false. What i
want to do is make sure that even if the target time is 4x, I'm not removing it
if it is less than 1x (without hard coding the value here). I'll improve the
comment before checking in.

Expand Messages | Collapse Messages