Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: net/disk_cache/entry_impl.cc

Issue 48112: Disk cache: First implementation of TrimDeleted() and a few... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/disk_cache/entry_impl.cc
===================================================================
--- net/disk_cache/entry_impl.cc (revision 11934)
+++ net/disk_cache/entry_impl.cc (working copy)
@@ -382,7 +382,7 @@
return base::CreatePlatformFile(backend_->GetFileName(address),
base::PLATFORM_FILE_OPEN |
base::PLATFORM_FILE_READ |
- base::PLATFORM_FILE_ASYNC,
+ base::PLATFORM_FILE_ASYNC,
NULL);
}
@@ -457,19 +457,25 @@
void EntryImpl::DeleteEntryData(bool everything) {
DCHECK(doomed_ || !everything);
- UMA_HISTOGRAM_COUNTS("DiskCache.DeleteHeader", GetDataSize(0));
- UMA_HISTOGRAM_COUNTS("DiskCache.DeleteData", GetDataSize(1));
+ if (GetDataSize(0))
+ UMA_HISTOGRAM_COUNTS("DiskCache.DeleteHeader", GetDataSize(0));
+ if (GetDataSize(1))
+ UMA_HISTOGRAM_COUNTS("DiskCache.DeleteData", GetDataSize(1));
for (int index = 0; index < NUM_STREAMS; index++) {
Addr address(entry_.Data()->data_addr[index]);
if (address.is_initialized()) {
DeleteData(address, index);
backend_->ModifyStorageSize(entry_.Data()->data_size[index] -
unreported_size_[index], 0);
+ entry_.Data()->data_addr[index] = 0;
+ entry_.Data()->data_size[index] = 0;
}
}
- if (!everything)
+ if (!everything) {
+ entry_.Store();
return;
+ }
// Remove all traces of this entry.
backend_->RemoveEntry(this);

Powered by Google App Engine
This is Rietveld 408576698