SSLPolicy Fix: Step 8....

SSLPolicy Fix: Step 8.

Cleanup the SSLPolicy API.  This should be the last reorganization patch.  The next step should be the substantive changes.

R=jcampan
BUG=8706
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11937

[jcampan, 2009-03-17 23:25:36]

LGTM with following nits.

http://codereview.chromium.org/48091/diff/1/2
File chrome/browser/ssl/ssl_manager.cc (right):

http://codereview.chromium.org/48091/diff/1/2#newcode721
Line 721: //               the HTTP request to https://attacker.com/payload.js..
Nit: extra . at the end

http://codereview.chromium.org/48091/diff/1/3
File chrome/browser/ssl/ssl_manager.h (right):

http://codereview.chromium.org/48091/diff/1/3#newcode264
Line 264: class RequestInfo : public base::RefCounted<RequestInfo> {
Would be nice to add a comment explaining the reason for that class.

http://codereview.chromium.org/48091/diff/11/14
File chrome/browser/ssl/ssl_policy.cc (right):

http://codereview.chromium.org/48091/diff/11/14#newcode51
Line 51: DISALLOW_EVIL_CONSTRUCTORS(ShowMixedContentTask);
Since you are changing this code, could you replace with
DISALLOW_COPY_AND_ASSIGN?

http://codereview.chromium.org/48091/diff/11/14#newcode197
Line 197: if (!entry)
Could you comment (may be with the same comment that was removed in the .h file)
when we cannot have a nav entry for mixed content?

[abarth-chromium, 2009-03-17 23:50:57]

http://codereview.chromium.org/48091/diff/1/2
File chrome/browser/ssl/ssl_manager.cc (right):

http://codereview.chromium.org/48091/diff/1/2#newcode721
Line 721: //               the HTTP request to https://attacker.com/payload.js..
Fixed.

http://codereview.chromium.org/48091/diff/1/3
File chrome/browser/ssl/ssl_manager.h (right):

http://codereview.chromium.org/48091/diff/1/3#newcode264
Line 264: class RequestInfo : public base::RefCounted<RequestInfo> {
Done.

http://codereview.chromium.org/48091/diff/11/14
File chrome/browser/ssl/ssl_policy.cc (right):

http://codereview.chromium.org/48091/diff/11/14#newcode51
Line 51: DISALLOW_EVIL_CONSTRUCTORS(ShowMixedContentTask);
Fixed.

http://codereview.chromium.org/48091/diff/11/14#newcode197
Line 197: if (!entry)
Done.