Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: chrome/browser/ssl/ssl_policy.h

Issue 48091: SSLPolicy Fix: Step 8.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/ssl_manager.cc ('k') | chrome/browser/ssl/ssl_policy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_policy.h
===================================================================
--- chrome/browser/ssl/ssl_policy.h (revision 11892)
+++ chrome/browser/ssl/ssl_policy.h (working copy)
@@ -22,17 +22,9 @@
static SSLPolicy* GetDefaultPolicy();
// SSLManager::Delegate methods.
- virtual void OnCertError(const GURL& main_frame_url,
- SSLManager::CertError* error);
- virtual void OnMixedContent(
- NavigationController* navigation_controller,
- const GURL& main_frame_url,
- SSLManager::MixedContentHandler* mixed_content_handler);
- virtual void OnRequestStarted(SSLManager* manager,
- const GURL& url,
- ResourceType::Type resource_type,
- int ssl_cert_id,
- int ssl_cert_status);
+ virtual void OnCertError(SSLManager::CertError* error);
+ virtual void OnMixedContent(SSLManager::MixedContentHandler* handler);
+ virtual void OnRequestStarted(SSLManager::RequestInfo* info);
virtual SecurityStyle GetDefaultStyle(const GURL& url);
// This method is static because it is called from both the UI and the IO
@@ -46,7 +38,7 @@
virtual void OnDenyCertificate(SSLManager::CertError* error);
virtual void OnAllowCertificate(SSLManager::CertError* error);
- protected:
+ private:
// Construct via |GetDefaultPolicy|.
SSLPolicy();
friend struct DefaultSingletonTraits<SSLPolicy>;
@@ -54,15 +46,12 @@
// Helper method for derived classes handling certificate errors that can be
// overridden by the user.
// Show a blocking page and let the user continue or cancel the request.
- void OnOverridableCertError(const GURL& main_frame_url,
- SSLManager::CertError* error);
+ void OnOverridableCertError(SSLManager::CertError* error);
// Helper method for derived classes handling fatal certificate errors.
// Cancel the request and show an error page.
- void OnFatalCertError(const GURL& main_frame_url,
- SSLManager::CertError* error);
+ void OnFatalCertError(SSLManager::CertError* error);
- private:
DISALLOW_COPY_AND_ASSIGN(SSLPolicy);
};
« no previous file with comments | « chrome/browser/ssl/ssl_manager.cc ('k') | chrome/browser/ssl/ssl_policy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698