Issue 4807001: AppCache: Alter the relative priorities of online vs fallback namespaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4807001: AppCache: Alter the relative priorities of online vs fallback namespaces. (Closed)

Created:
10 years, 1 month ago by michaeln

Modified:
9 years, 7 months ago

Reviewers:
kinuko

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Alter the relative priorities of network vs fallback namespaces in the appcache. If a resource url is in an appcache's network namespace and fallback namespace, the network namespace wins (with the exception of the special '*' network namespace which does not take priority over the fallback namespace. BUG=WK49292 TEST=unit test, also a new layout test (not landed yet) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66731

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -16 lines)			Patch
M	webkit/appcache/appcache.h	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	webkit/appcache/appcache.cc	View	1	3 chunks	+15 lines, -9 lines	1 comment	Download
M	webkit/appcache/appcache_storage_impl.cc	View	1 2 3	2 chunks	+46 lines, -1 line	0 comments	Download
M	webkit/appcache/appcache_storage_impl_unittest.cc	View		5 chunks	+37 lines, -5 lines	1 comment	Download
M	webkit/appcache/appcache_unittest.cc	View	2 3	3 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

michaeln

Here's the webkit bug for this. https://bugs.webkit.org/show_bug.cgi?id=49292

10 years, 1 month ago (2010-11-17 21:47:08 UTC) #1

michaeln

On 2010/11/17 21:47:08, michaeln wrote: > Here's the webkit bug for this. > https://bugs.webkit.org/show_bug.cgi?id=49292 The ...

10 years, 1 month ago (2010-11-18 04:09:21 UTC) #2

kinuko

10 years, 1 month ago (2010-11-19 00:28:51 UTC) #3

LGTM with a few nits.

http://codereview.chromium.org/4807001/diff/24001/webkit/appcache/appcache.cc
File webkit/appcache/appcache.cc (right):

http://codereview.chromium.org/4807001/diff/24001/webkit/appcache/appcache.cc...
webkit/appcache/appcache.cc:242: if (StartsWithASCII( url.spec(),
namespaces[i].spec(), true))
nit: extra space before url.spec()

http://codereview.chromium.org/4807001/diff/24001/webkit/appcache/appcache_st...
File webkit/appcache/appcache_storage_impl_unittest.cc (right):

http://codereview.chromium.org/4807001/diff/24001/webkit/appcache/appcache_st...
webkit/appcache/appcache_storage_impl_unittest.cc:997: // in the fallback
namespace.
nit: 'in the' is duplicated?

Expand Messages | Collapse Messages