SSLPolicy Fix: Step 5....

SSLPolicy Fix: Step 5.

Add a new notification type to notify other SSLManagers when a security origin becomes contaminated with mixed content.

TBR=wtc
BUG=8706
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11853

[abarth-chromium, 2009-03-17 10:09:27]

I'm sending this TBR since the change is trivial.

[wtc, 2009-03-17 17:59:08]

LGTM.

I have a question below, but this CL is definitely correct.
Basically you mapped the current SSL_STATE_CHANGED to
the new SSL_VISIBLE_STATE_CHANGED.

Cc'ing jcampan as an FYI.

http://codereview.chromium.org/48059/diff/1/3
File chrome/common/notification_type.h (right):

http://codereview.chromium.org/48059/diff/1/3#newcode139
Line 139: // case.  Listen to this notification if you need to refresh
SSL-related UI
I'm still not quite clear on the distinction between visible
and internal.  Aren't they linked?  For example, if we have
an internal state change, don't we need to refresh the SSL
UI to reflect that?

[abarth-chromium, 2009-03-17 18:10:42]

http://codereview.chromium.org/48059/diff/1/3
File chrome/common/notification_type.h (right):

http://codereview.chromium.org/48059/diff/1/3#newcode139
Line 139: // case.  Listen to this notification if you need to refresh
SSL-related UI
Updating the SSL UI will proceed in two phases:

1) A SSLManager changes the SSLHostState.  It broadcasts a
SSL_INTERNAL_STATE_CHANGED notification.

2) The SSLManager for each tab receives this notification and might or might not
update its navigation entry.  If it does change the navigation entry, it sends
out an SSL_VISIBLE_STATE_CHANGED notification to the user interface can redraw
properly.

Maybe I should add this as a comment here?

[wtc, 2009-03-17 20:17:15]

On 2009/03/17 18:10:42, abarth wrote:
> http://codereview.chromium.org/48059/diff/1/3
> File chrome/common/notification_type.h (right):
> 
> http://codereview.chromium.org/48059/diff/1/3#newcode139
> Line 139: // case.  Listen to this notification if you need to refresh
> SSL-related UI
> Updating the SSL UI will proceed in two phases:
> 
> 1) A SSLManager changes the SSLHostState.  It broadcasts a
> SSL_INTERNAL_STATE_CHANGED notification.
> 
> 2) The SSLManager for each tab receives this notification and might or might
not
> update its navigation entry.  If it does change the navigation entry, it sends
> out an SSL_VISIBLE_STATE_CHANGED notification to the user interface can redraw
> properly.
> 
> Maybe I should add this as a comment here?

Yes, please.  Thanks!