SSLPolicy Fix: Step 5....

chrome/common/notification_type.h

Index: chrome/common/notification_type.h
===================================================================
--- chrome/common/notification_type.h	(revision 11852)
+++ chrome/common/notification_type.h	(working copy)
@@ -132,16 +132,27 @@
     // are provided.
     RESOURCE_RECEIVED_REDIRECT,
 
-    // The SSL state of a page has changed somehow. For example, if an insecure
-    // resource is loaded on a secure page. Note that a toplevel load commit
-    // will also update the SSL state (since the NavigationEntry is new) and
-    // this message won't always be sent in that case.
+    // The SSL state of a page has changed in some visible way.  For example,
+    // if an insecure resource is loaded on a secure page.  Note that a
+    // toplevel load commit will also update the SSL state (since the
+    // NavigationEntry is new) and this message won't always be sent in that
+    // case.  Listen to this notification if you need to refresh SSL-related UI

[wtc, 2009/03/17 17:59:08]

I'm still not quite clear on the distinction between visible
and internal.  Aren't they linked?  For example, if we have
an internal state change, don't we need to refresh the SSL
UI to reflect that?

[abarth-chromium, 2009/03/17 18:10:42]

Updating the SSL UI will proceed in two phases:

1) A SSLManager changes the SSLHostState.  It broadcasts a
SSL_INTERNAL_STATE_CHANGED notification.

2) The SSLManager for each tab receives this notification and might or might not
update its navigation entry.  If it does change the navigation entry, it sends
out an SSL_VISIBLE_STATE_CHANGED notification to the user interface can redraw
properly.

Maybe I should add this as a comment here?

+    // elements.
     //
     // The source will be the navigation controller associated with the load.
-    // There are no details. The entry changed will be the active entry of the
+    // There are no details.  The entry changed will be the active entry of the
     // controller.
-    SSL_STATE_CHANGED,
+    SSL_VISIBLE_STATE_CHANGED,
 
+    // The SSL state of the browser has changed in some internal way.  For
+    // example, the user might have explicitly allowed some broken certificate
+    // or a secure origin might have included some insecure content.  Listen to
+    // this notifiation if you need to keep track of our internal SSL state.
+    //
+    // The source will be the navigation controller associated with the state
+    // change.  There are no details.
+    SSL_INTERNAL_STATE_CHANGED,
+
     // Download start and stop notifications. Stop notifications can occur on
     // both normal completion or via a cancel operation.
     DOWNLOAD_START, DOWNLOAD_STOP,