Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5936)

Unified Diff: chrome/test/test_launcher_utils.cc

Issue 4784001: Removed --use-gl=osmesa as default for ui and browser tests.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/test_launcher_utils.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/test_launcher_utils.cc
===================================================================
--- chrome/test/test_launcher_utils.cc (revision 65684)
+++ chrome/test/test_launcher_utils.cc (working copy)
@@ -2,8 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "app/app_switches.h"
#include "base/command_line.h"
#include "base/environment.h"
+#include "base/logging.h"
#include "base/path_service.h"
#include "base/scoped_ptr.h"
#include "chrome/common/chrome_paths.h"
@@ -53,4 +55,9 @@
return success;
}
+void OverrideGLImplementation(CommandLine* command_line,
+ const char* implementation_name) {
+ DCHECK(!command_line->HasSwitch(switches::kUseGL));
Paweł Hajdan Jr. 2010/11/11 10:24:52 Can we avoid DCHECKs in test code? How about makin
apatrick_chromium 2010/11/11 23:28:33 Done.
+ command_line->AppendSwitchASCII(switches::kUseGL, implementation_name);
+}
Paweł Hajdan Jr. 2010/11/11 10:24:52 nit: Add empty line below.
apatrick_chromium 2010/11/11 23:28:33 Done.
} // namespace test_launcher_utils
« no previous file with comments | « chrome/test/test_launcher_utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698