Removed --use-gl=osmesa as default for ui and browser tests....

chrome/test/test_launcher_utils.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "app/app_switches.h"
 #include "base/command_line.h"
 #include "base/environment.h"
+#include "base/logging.h"
 #include "base/path_service.h"
 #include "base/scoped_ptr.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/test_launcher_utils.h"
 
 namespace test_launcher_utils {
 
 void PrepareBrowserCommandLineForTests(CommandLine* command_line) {
   // Turn off tip loading for tests; see http://crbug.com/17725.
@@ skipping 29 matching lines @@
   //
   // Note: we use an environment variable here, because we have to pass the
   // value to the child process. This is the simplest way to do it.
   scoped_ptr<base::Environment> env(base::Environment::Create());
   success = success && env->SetVar("XDG_CACHE_HOME", user_data_dir.value());
 #endif
 
   return success;
 }
 
+void OverrideGLImplementation(CommandLine* command_line,
+                              const char* implementation_name) {
+  DCHECK(!command_line->HasSwitch(switches::kUseGL));

[Paweł Hajdan Jr., 2010/11/11 10:24:52]

Can we avoid DCHECKs in test code? How about making it return bool and adding
WARN_UNUSED_RESULT from base/compiler_specific.h?

[apatrick_chromium, 2010/11/11 23:28:33]

Done.

+  command_line->AppendSwitchASCII(switches::kUseGL, implementation_name);
+}

[Paweł Hajdan Jr., 2010/11/11 10:24:52]

nit: Add empty line below.

[apatrick_chromium, 2010/11/11 23:28:33]

Done.

 }  // namespace test_launcher_utils