Issue 4784001: Removed --use-gl=osmesa as default for ui and browser tests....

Issue 4784001: Removed --use-gl=osmesa as default for ui and browser tests.... (Closed)

Created:
10 years, 1 month ago by apatrick_chromium

Modified:
10 years, 1 month ago

Reviewers:
Paweł Hajdan Jr., Nirnimesh

CC:
chromium-reviews, ben+cc_chromium.org, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Removed --use-gl=osmesa as default for ui and browser tests. Some tests require regular GL and appear not to be flaky. This command line switch is now only passed to tests that are flaky on bots using regular GL. TEST=run affected tests locally, try BUG=55477, 62602 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66177

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 4

Patch Set 4 : '' #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -47 lines)			Patch
M	chrome/browser/media_uitest.cc	View	1 2 3	3 chunks	+24 lines, -31 lines	0 comments	Download
M	chrome/test/gpu/gpu_browsertest.cc	View	1 2 3	3 chunks	+19 lines, -3 lines	0 comments	Download
M	chrome/test/gpu/gpu_uitest.cc	View	1 2 3	2 chunks	+15 lines, -3 lines	0 comments	Download
M	chrome/test/in_process_browser_test.cc	View	1 2 3	2 chunks	+0 lines, -10 lines	0 comments	Download
M	chrome/test/test_launcher_utils.h	View	1 2 3	1 chunk	+6 lines, -0 lines	1 comment	Download
M	chrome/test/test_launcher_utils.cc	View	1 2 3	2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

http://codereview.chromium.org/4784001/diff/18001/chrome/test/test_launcher_utils.cc File chrome/test/test_launcher_utils.cc (right): http://codereview.chromium.org/4784001/diff/18001/chrome/test/test_launcher_utils.cc#newcode60 chrome/test/test_launcher_utils.cc:60: DCHECK(!command_line->HasSwitch(switches::kUseGL)); Can we avoid DCHECKs in test code? How ...

10 years, 1 month ago (2010-11-11 10:24:52 UTC) #3

apatrick_chromium

10 years, 1 month ago (2010-11-11 23:28:33 UTC) #4

Paweł Hajdan Jr.

10 years, 1 month ago (2010-11-12 08:47:50 UTC) #5

LGTM with nit. Thanks!

http://codereview.chromium.org/4784001/diff/27001/chrome/test/test_launcher_u...
File chrome/test/test_launcher_utils.h (right):

http://codereview.chromium.org/4784001/diff/27001/chrome/test/test_launcher_u...
chrome/test/test_launcher_utils.h:28: const char* implementation_name)
WARN_UNUSED_RESULT;
nit: Use const std::string& instead of const char* if possible.

Expand Messages | Collapse Messages