Split the private webstore install API into two parts....

chrome/browser/extensions/extension_webstore_private_api.h

Index: chrome/browser/extensions/extension_webstore_private_api.h
===================================================================
--- chrome/browser/extensions/extension_webstore_private_api.h	(revision 65457)
+++ chrome/browser/extensions/extension_webstore_private_api.h	(working copy)
@@ -25,14 +25,29 @@
   static void SetTestingBrowserSignin(BrowserSignin* signin);
 };
 
+// TODO(asargent) - this function is deprecated. We can remove it sometime
+// after the chrome milestone 9 timeframe.

[Erik does not do reviews, 2010/11/09 16:32:21]

why can't we just remove it?  I don't think anything that's released in the
store actually uses it yet.

[asargent_no_longer_on_chrome, 2010/11/10 00:23:48]

Ok, removed

 class InstallFunction : public SyncExtensionFunction {
+  virtual bool RunImpl();
+  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.install");
+};
+
+class BeginInstallFunction : public SyncExtensionFunction {
  public:
+  // For use only in tests - sets a flag that can cause this function to ignore
+  // the normal requirement that it is called during a user gesture.
+  static void SetIgnoreUserGestureForTests(bool ignore);
+ protected:
+  virtual bool RunImpl();
+  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.beginInstall");
+};
+
+class CompleteInstallFunction : public SyncExtensionFunction {
+ public:
   static void SetTestingInstallBaseUrl(const char* testing_install_base_url);

[Erik does not do reviews, 2010/11/09 16:32:21]

add comment

[asargent_no_longer_on_chrome, 2010/11/10 00:23:48]

Done.

-
  protected:
-  ~InstallFunction() {}
   virtual bool RunImpl();
-  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.install");
+  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.completeInstall");
 };
 
 class GetBrowserLoginFunction : public SyncExtensionFunction {