Split the private webstore install API into two parts....

chrome/browser/extensions/extension_webstore_private_api.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_WEBSTORE_PRIVATE_API_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_WEBSTORE_PRIVATE_API_H_
 #pragma once
 
 #include "chrome/browser/browser_signin.h"
 #include "chrome/browser/extensions/extension_function.h"
 #include "chrome/common/net/gaia/google_service_auth_error.h"
 #include "chrome/common/notification_observer.h"
 #include "chrome/common/notification_registrar.h"
 
 class ProfileSyncService;
 
 class WebstorePrivateApi {
  public:
   // Allows you to set the ProfileSyncService the function will use for
   // testing purposes.
   static void SetTestingProfileSyncService(ProfileSyncService* service);
 
   // Allows you to set the BrowserSignin the function will use for
   // testing purposes.
   static void SetTestingBrowserSignin(BrowserSignin* signin);
 };
 
+// TODO(asargent) - this function is deprecated. We can remove it sometime
+// after the chrome milestone 9 timeframe.

[Erik does not do reviews, 2010/11/09 16:32:21]

why can't we just remove it?  I don't think anything that's released in the
store actually uses it yet.

[asargent_no_longer_on_chrome, 2010/11/10 00:23:48]

Ok, removed

 class InstallFunction : public SyncExtensionFunction {
- public:
-  static void SetTestingInstallBaseUrl(const char* testing_install_base_url);
-
- protected:
-  ~InstallFunction() {}
   virtual bool RunImpl();
   DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.install");
 };
 
+class BeginInstallFunction : public SyncExtensionFunction {
+ public:
+  // For use only in tests - sets a flag that can cause this function to ignore
+  // the normal requirement that it is called during a user gesture.
+  static void SetIgnoreUserGestureForTests(bool ignore);
+ protected:
+  virtual bool RunImpl();
+  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.beginInstall");
+};
+
+class CompleteInstallFunction : public SyncExtensionFunction {
+ public:
+  static void SetTestingInstallBaseUrl(const char* testing_install_base_url);

[Erik does not do reviews, 2010/11/09 16:32:21]

add comment

[asargent_no_longer_on_chrome, 2010/11/10 00:23:48]

Done.

+ protected:
+  virtual bool RunImpl();
+  DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.completeInstall");
+};
+
 class GetBrowserLoginFunction : public SyncExtensionFunction {
   virtual bool RunImpl();
   DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.getBrowserLogin");
 };
 
 class GetStoreLoginFunction : public SyncExtensionFunction {
   virtual bool RunImpl();
   DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.getStoreLogin");
 };
 
@@ skipping 27 matching lines @@
   // Are we waiting for a token available notification?
   bool waiting_for_token_;
 
   // Used for listening for TokenService notifications.
   NotificationRegistrar registrar_;
 
   DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.promptBrowserLogin");
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_WEBSTORE_PRIVATE_API_H_