chrome/browser/extensions/extension_install_ui.cc - Issue 4724005: Add a help bubble pointing to the omnibox when installing an extension with

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_install_ui.cc

Issue 4724005: Add a help bubble pointing to the omnibox when installing an extension with (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: xib Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/cocoa/extension_installed_bubble_controller_unittest.mm ('k') | chrome/browser/gtk/extension_installed_bubble_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_install_ui.cc

diff --git a/chrome/browser/extensions/extension_install_ui.cc b/chrome/browser/extensions/extension_install_ui.cc

index 3c5f8199f400051814806053e616ab5456d445c2..2f1efd5039644cac91196e62f75da7d02cef0f25 100644

--- a/chrome/browser/extensions/extension_install_ui.cc

+++ b/chrome/browser/extensions/extension_install_ui.cc

@@ -155,6 +155,7 @@ void ExtensionInstallUI::OnInstallSuccess(const Extension* extension) {

// Note that browser actions don't appear in incognito mode initially,

// so fall back to the generic case.

if ((extension->browser_action() && !browser->profile()->IsOffTheRecord()) ||

+ !extension->omnibox_keyword().empty() ||

(extension->page_action() &&

!extension->page_action()->default_icon_path().empty())) {

ExtensionInstalledBubbleCocoa::ShowExtensionInstalledBubble(