Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4553)

Unified Diff: chrome/browser/cocoa/extension_installed_bubble_controller_unittest.mm

Issue 4724005: Add a help bubble pointing to the omnibox when installing an extension with (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: xib Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/extension_installed_bubble_controller_unittest.mm
diff --git a/chrome/browser/cocoa/extension_installed_bubble_controller_unittest.mm b/chrome/browser/cocoa/extension_installed_bubble_controller_unittest.mm
index ad68c853962bc355981390bbf50a620c471793fd..911396067a8f8a41896e66ae41422f3293f28711 100644
--- a/chrome/browser/cocoa/extension_installed_bubble_controller_unittest.mm
+++ b/chrome/browser/cocoa/extension_installed_bubble_controller_unittest.mm
@@ -141,7 +141,7 @@ TEST_F(ExtensionInstalledBubbleControllerTest, PageActionTest) {
2 * extension_installed_bubble::kInnerVerticalMargin +
[controller getExtensionInstalledMsgFrame].size.height +
[controller getExtensionInstalledInfoMsgFrame].size.height +
- [controller getPageActionInfoMsgFrame].size.height;
+ [controller getExtraInfoMsgFrame].size.height;
EXPECT_EQ(height, correctHeight);
[controller setMessageFrames:height];
@@ -149,7 +149,7 @@ TEST_F(ExtensionInstalledBubbleControllerTest, PageActionTest) {
// Bottom message should be kOuterVerticalMargin pixels above window edge.
EXPECT_EQ(msg3Frame.origin.y,
extension_installed_bubble::kOuterVerticalMargin);
- NSRect msg2Frame = [controller getPageActionInfoMsgFrame];
+ NSRect msg2Frame = [controller getExtraInfoMsgFrame];
// Pageaction message should be kInnerVerticalMargin pixels above bottom msg.
EXPECT_EQ(msg2Frame.origin.y,
msg3Frame.origin.y + msg3Frame.size.height +
« no previous file with comments | « chrome/browser/cocoa/extension_installed_bubble_controller.mm ('k') | chrome/browser/extensions/extension_install_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698