Issue 4715001: Merge 65401 - A bunch of proxy DOMUI changes....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4715001: Merge 65401 - A bunch of proxy DOMUI changes.... (Closed)

Created:
10 years, 1 month ago by xiyuan

Modified:
9 years, 7 months ago

Reviewers:
zel

CC:
chromium-reviews, dhg, Paweł Hajdan Jr., arv (Not doing code reviews), davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/552c/src/

Visibility:
Public.

Merge 65401 - A bunch of proxy DOMUI changes. - Make sure invalid manual proxy changes can be changed to valid; - Disable single proxy when manual proxy is not checked; - Clearing manual settings take effect; Kuan fixed the backend and I fixed the DOMUI. BUG=chromium-os:8703, chromium-os:8683, chromium-os:8710 TEST=Verify per bug report. Review URL: http://codereview.chromium.org/4580001 TBR=zelidrag@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65415

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+125 lines, -125 lines)			Patch
M	chrome/browser/browser_resources.grd	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/cros_settings_provider_proxy.h	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/cros_settings_provider_proxy.cc	View	8 chunks	+94 lines, -73 lines	0 comments	Download
M	chrome/browser/chromeos/proxy_config_service_impl.cc	View	3 chunks	+6 lines, -18 lines	0 comments	Download
M	chrome/browser/chromeos/proxy_config_service_impl_unittest.cc	View	1 chunk	+15 lines, -28 lines	0 comments	Download
M	chrome/browser/resources/options/chromeos_proxy_options.js	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM

approved for merge