A bunch of proxy DOMUI changes.

A bunch of proxy DOMUI changes.
    
- Make sure invalid manual proxy changes can be changed to valid;
- Disable single proxy when manual proxy is not checked;
- Clearing manual settings take effect;
    
Kuan fixed the backend and I fixed the DOMUI.
    
BUG=chromium-os:8703, chromium-os:8683, chromium-os:8710
TEST=Verify per bug report.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65401

[kuan, 2010-11-05 21:30:09]

LGTM.

thank you so very much for helping me fix the problem and land this cl!

http://codereview.chromium.org/4580001/diff/2001/3002
File chrome/browser/chromeos/cros_settings_provider_proxy.cc (right):

http://codereview.chromium.org/4580001/diff/2001/3002#newcode16
chrome/browser/chromeos/cros_settings_provider_proxy.cc:16: static const char
kProxySignleHttpPort[] = "cros.proxy.singlehttpport";
typo: kProxySingleHttpPort

http://codereview.chromium.org/4580001/diff/2001/3002#newcode184
chrome/browser/chromeos/cros_settings_provider_proxy.cc:184:
net::ProxyServer::FromURI(uri, net::ProxyServer::SCHEME_SOCKS5));
sorry i didn't notice this earlier, but we shld use SCHEME_SOCKS4.

http://codereview.chromium.org/4580001/diff/2001/3002#newcode295
chrome/browser/chromeos/cros_settings_provider_proxy.cc:295: if
(!server_uri->empty() && cache_.GetString(port_cache_key, &port)) {
we need to check if port->empty() and only append port if it's not.

http://codereview.chromium.org/4580001/diff/2001/3002#newcode304
chrome/browser/chromeos/cros_settings_provider_proxy.cc:304: if
(!port_num.empty())
maybe we shld combine if ((cache_.GetString...) && !server_uri.empty() &&
!port_num.empty())

[xiyuan, 2010-11-05 21:54:52]

http://codereview.chromium.org/4580001/diff/2001/3002
File chrome/browser/chromeos/cros_settings_provider_proxy.cc (right):

http://codereview.chromium.org/4580001/diff/2001/3002#newcode16
chrome/browser/chromeos/cros_settings_provider_proxy.cc:16: static const char
kProxySignleHttpPort[] = "cros.proxy.singlehttpport";
On 2010/11/05 21:30:10, kuan wrote:
> typo: kProxySingleHttpPort

Done.

http://codereview.chromium.org/4580001/diff/2001/3002#newcode184
chrome/browser/chromeos/cros_settings_provider_proxy.cc:184:
net::ProxyServer::FromURI(uri, net::ProxyServer::SCHEME_SOCKS5));
On 2010/11/05 21:30:10, kuan wrote:
> sorry i didn't notice this earlier, but we shld use SCHEME_SOCKS4.

Done.

http://codereview.chromium.org/4580001/diff/2001/3002#newcode295
chrome/browser/chromeos/cros_settings_provider_proxy.cc:295: if
(!server_uri->empty() && cache_.GetString(port_cache_key, &port)) {
On 2010/11/05 21:30:10, kuan wrote:
> we need to check if port->empty() and only append port if it's not.

Done.

http://codereview.chromium.org/4580001/diff/2001/3002#newcode304
chrome/browser/chromeos/cros_settings_provider_proxy.cc:304: if
(!port_num.empty())
On 2010/11/05 21:30:10, kuan wrote:
> maybe we shld combine if ((cache_.GetString...) && !server_uri.empty() &&
> !port_num.empty())

Done.

[kuan, 2010-11-08 17:42:45]

LGTM.

thanks for making the changes!

On 2010/11/05 21:54:52, xiyuan wrote:
> http://codereview.chromium.org/4580001/diff/2001/3002
> File chrome/browser/chromeos/cros_settings_provider_proxy.cc (right):
> 
> http://codereview.chromium.org/4580001/diff/2001/3002#newcode16
> chrome/browser/chromeos/cros_settings_provider_proxy.cc:16: static const char
> kProxySignleHttpPort[] = "cros.proxy.singlehttpport";
> On 2010/11/05 21:30:10, kuan wrote:
> > typo: kProxySingleHttpPort
> 
> Done.
> 
> http://codereview.chromium.org/4580001/diff/2001/3002#newcode184
> chrome/browser/chromeos/cros_settings_provider_proxy.cc:184:
> net::ProxyServer::FromURI(uri, net::ProxyServer::SCHEME_SOCKS5));
> On 2010/11/05 21:30:10, kuan wrote:
> > sorry i didn't notice this earlier, but we shld use SCHEME_SOCKS4.
> 
> Done.
> 
> http://codereview.chromium.org/4580001/diff/2001/3002#newcode295
> chrome/browser/chromeos/cros_settings_provider_proxy.cc:295: if
> (!server_uri->empty() && cache_.GetString(port_cache_key, &port)) {
> On 2010/11/05 21:30:10, kuan wrote:
> > we need to check if port->empty() and only append port if it's not.
> 
> Done.
> 
> http://codereview.chromium.org/4580001/diff/2001/3002#newcode304
> chrome/browser/chromeos/cros_settings_provider_proxy.cc:304: if
> (!port_num.empty())
> On 2010/11/05 21:30:10, kuan wrote:
> > maybe we shld combine if ((cache_.GetString...) && !server_uri.empty() &&
> > !port_num.empty())
> 
> Done.

[zel, 2010-11-08 17:58:37]

LGTM

also, I think we should take this one into 552c branch as well