Split out command IDs from chrome_dll_resource.h.

Split out command IDs from chrome_dll_resource.h.

The name of this file is a leftover from Windows.  Split the command
ids (which are used on all platforms) out, leaving just the
Windows-specific resource IDs in the original file.

TEST=compiles

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65453

[Evan Martin, 2010-11-08 22:50:27]

to make hte review simpler, note that all "1 chunk 14 lines" diffs are just
header renamse

[Evan Martin, 2010-11-08 22:50:54]

http://codereview.chromium.org/4710001/diff/1/3
File chrome/app/chrome_dll_resource.h (left):

http://codereview.chromium.org/4710001/diff/1/3#oldcode260
chrome/app/chrome_dll_resource.h:260: #endif
I deleted this block as well

[tony, 2010-11-08 23:10:47]

LGTM.  I just spot checked a few files.

http://codereview.chromium.org/4710001/diff/1/111
File chrome/chrome_exe.gypi (right):

http://codereview.chromium.org/4710001/diff/1/111#newcode203
chrome/chrome_exe.gypi:203: 'app/chrome_command_ids.h',
Does this target actually use chrome_command_ids.h?

[Ben Goodger (Google), 2010-11-09 01:18:47]

http://codereview.chromium.org/4710001/diff/1/2
File chrome/app/chrome_command_ids.h (right):

http://codereview.chromium.org/4710001/diff/1/2#newcode1
chrome/app/chrome_command_ids.h:1: // Copyright (c) 2010 The Chromium Authors.
All rights reserved.
Would it make sense for this file to live in src/chrome/browser/ui now?

[evanm, 2010-11-09 01:28:07]

On 2010/11/09 01:18:47, Ben Goodger wrote:
> Would it make sense for this file to live in src/chrome/browser/ui now?

Yeah!  That is part of the reason I'm tackling this directory, it's filled with
all sorts of stuff that belongs elsewhere.  (In parallel I've been working on
moving some code from here into browser_main, allowing me to delete a bunch of
code in a place where it had been copied.)

I guess it's easy enough to rename now, though I note a bunch of other
directories (like workers for some reason) reach into it.  I guess those would
need to be fixed first.