chrome/browser/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm - Issue 4710001: Split out command IDs from chrome_dll_resource.h.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

Issue 4710001: Split out command IDs from chrome_dll_resource.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import "chrome/browser/cocoa/bookmarks/bookmark_menu_cocoa_controller.h"	5 #import "chrome/browser/cocoa/bookmarks/bookmark_menu_cocoa_controller.h"

6	6

7 #include "app/text_elider.h"	7 #include "app/text_elider.h"

8 #include "base/sys_string_conversions.h"	8 #include "base/sys_string_conversions.h"

9 #include "base/utf_string_conversions.h"	9 #include "base/utf_string_conversions.h"

10 #include "chrome/app/chrome_dll_resource.h" // IDC_BOOKMARK_MENU	10 #include "chrome/app/chrome_command_ids.h" // IDC_BOOKMARK_MENU

11 #import "chrome/browser/app_controller_mac.h"	11 #import "chrome/browser/app_controller_mac.h"

12 #include "chrome/browser/bookmarks/bookmark_model.h"	12 #include "chrome/browser/bookmarks/bookmark_model.h"

13 #include "chrome/browser/browser.h"	13 #include "chrome/browser/browser.h"

14 #import "chrome/browser/cocoa/bookmarks/bookmark_menu_bridge.h"	14 #import "chrome/browser/cocoa/bookmarks/bookmark_menu_bridge.h"

15 #include "chrome/browser/cocoa/event_utils.h"	15 #include "chrome/browser/cocoa/event_utils.h"

16 #include "chrome/browser/browser_process.h"	16 #include "chrome/browser/browser_process.h"

17 #include "chrome/browser/tab_contents/tab_contents.h"	17 #include "chrome/browser/tab_contents/tab_contents.h"

18 #include "webkit/glue/window_open_disposition.h"	18 #include "webkit/glue/window_open_disposition.h"

19	19

20 namespace {	20 namespace {

(...skipping 68 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
89 const BookmarkNode* node = [self nodeForIdentifier:identifier];	89 const BookmarkNode* node = [self nodeForIdentifier:identifier];

90 DCHECK(node);	90 DCHECK(node);

91 if (!node)	91 if (!node)

92 return; // shouldn't be reached	92 return; // shouldn't be reached

93	93

94 [self openURLForNode:node];	94 [self openURLForNode:node];

95 }	95 }

96	96

97 @end // BookmarkMenuCocoaController	97 @end // BookmarkMenuCocoaController

98	98

OLD	NEW