Issue 4708008: views: Override gtk-menu-images=0 for menu items with icons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4708008: views: Override gtk-menu-images=0 for menu items with icons. (Closed)

Created:
10 years, 1 month ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, ben+cc_chromium.org, Nathan Williams

Base URL:
svn://svn.chromium.org/chrome/trunk/src/views

Visibility:
Public.

Description

views: Override gtk-menu-images=0 for menu items with icons. This lets us disable icons by default, which gets rid of the ugly GTK+ copy/cut/paste icons in stock menus while still showing icons for Views menu items that have explicitly asked for them, like the ones in the Chrome OS network menu. BUG=chromium-os:4345 TEST=built and ran it Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65828

Patch Set 1 #

Patch Set 2 : add GTK_CHECK_VERSION around gtk_image_menu_item_set_always_show_image() #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	views/controls/menu/native_menu_gtk.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages