Do not allow network status updates while password field is active.

Do not allow network status updates while password field is active.

BUG=chromium-os:8304
TEST=manually show password field (click on password protected wireless network or "join other network...") and make some network change (disconnect ethernet cable etc.), and check if the status is unchanged, then close the password field by any possible means and check if status update is working.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65617

[kochi, 2010-11-09 11:30:17]

Hi Charlie,

Could you review this?

Thanks!

[Charlie Lee, 2010-11-09 17:53:45]

LGTM

http://codereview.chromium.org/4705003/diff/1/2
File chrome/browser/resources/options/chromeos_internet_network_element.js
(right):

http://codereview.chromium.org/4705003/diff/1/2#newcode295
chrome/browser/resources/options/chromeos_internet_network_element.js:295:
InternetOptions.lockUpdates();
maybe put this at the beginning of the method?

http://codereview.chromium.org/4705003/diff/1/2#newcode407
chrome/browser/resources/options/chromeos_internet_network_element.js:407:
InternetOptions.lockUpdates();
maybe put this at the beginning of the method?

[kochi, 2010-11-10 01:16:45]

Thanks for the review!

I think moving function call to earlier in the function
does not make any difference, but to be symmetric with unlock
I think the new position is more comfortable.

I am submiting soon...

On 2010/11/09 17:53:45, Charlie Lee wrote:
> LGTM
> 
> http://codereview.chromium.org/4705003/diff/1/2
> File chrome/browser/resources/options/chromeos_internet_network_element.js
> (right):
> 
> http://codereview.chromium.org/4705003/diff/1/2#newcode295
> chrome/browser/resources/options/chromeos_internet_network_element.js:295:
> InternetOptions.lockUpdates();
> maybe put this at the beginning of the method?
> 
> http://codereview.chromium.org/4705003/diff/1/2#newcode407
> chrome/browser/resources/options/chromeos_internet_network_element.js:407:
> InternetOptions.lockUpdates();
> maybe put this at the beginning of the method?

[kochi, 2010-11-10 02:31:21]

Seems something went wrong for sending review comments...

http://codereview.chromium.org/4705003/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/chromeos_internet_network_element.js
(right):

http://codereview.chromium.org/4705003/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/chromeos_internet_network_element.js:295:
InternetOptions.lockUpdates();
On 2010/11/09 17:53:45, Charlie Lee wrote:
> maybe put this at the beginning of the method?

Done.

http://codereview.chromium.org/4705003/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/chromeos_internet_network_element.js:407:
InternetOptions.lockUpdates();
On 2010/11/09 17:53:46, Charlie Lee wrote:
> maybe put this at the beginning of the method?

Done.

[Charlie Lee, 2010-11-10 02:33:54]

LGTM