Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: chrome/browser/resources/options/chromeos_internet_network_element.js

Issue 4705003: Do not allow network status updates while password field is active. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fix. Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/options/chromeos_internet_options.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/chromeos_internet_network_element.js
diff --git a/chrome/browser/resources/options/chromeos_internet_network_element.js b/chrome/browser/resources/options/chromeos_internet_network_element.js
index 7541f2b314289c7ed594de034c50f82eaa00899e..93a7a406862405f566f57e9e30f3a237ea33abd0 100644
--- a/chrome/browser/resources/options/chromeos_internet_network_element.js
+++ b/chrome/browser/resources/options/chromeos_internet_network_element.js
@@ -70,6 +70,7 @@ cr.define('options.internet', function() {
if (this.childNodes[i] != item)
this.childNodes[i].hidePassword();
}
+ InternetOptions.unlockUpdates();
// If clicked on other networks item.
if (data && data.servicePath == '?') {
item.showOtherLogin();
@@ -254,6 +255,9 @@ cr.define('options.internet', function() {
showPassword: function() {
if (this.connecting)
return;
+
+ InternetOptions.lockUpdates();
+
var passwordDiv = this.ownerDocument.createElement('div');
passwordDiv.className = 'network-password';
var passInput = this.ownerDocument.createElement('input');
@@ -317,6 +321,8 @@ cr.define('options.internet', function() {
if (this.connecting)
return;
+ InternetOptions.lockUpdates();
+
var ssidDiv = this.ownerDocument.createElement('div');
ssidDiv.className = 'network-password';
var ssidInput = this.ownerDocument.createElement('input');
« no previous file with comments | « no previous file | chrome/browser/resources/options/chromeos_internet_options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698