Issue 4690006: AU: Execute postinst asynchronously so that the D-Bus service is not blocked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4690006: AU: Execute postinst asynchronously so that the D-Bus service is not blocked. (Closed)

Created:
10 years, 1 month ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git@master

Visibility:
Public.

Description

AU: Execute postinst asynchronously so that the D-Bus service is not blocked. This CL also cleans up Subprocess memory handling a bit and extends it to capture the output of asynchronous subprocesses. Also adds a scoped temp mount unmounter utility class. BUG=8937 TEST=unit tests, tested on the device -- making sure no D-Bus calls timeou during postinstall. Change-Id: I219dda3dc98d875ff05050f1a32ffcc925db1d53 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=6f03a3b

Patch Set 1 #

Patch Set 2 : fix copyright #

Patch Set 3 : remove unnecessary log #

Total comments: 2

Patch Set 4 : address review comments #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+257 lines, -104 lines)			Patch
M	postinstall_runner_action.h	View		3 chunks	+10 lines, -2 lines	0 comments	Download
M	postinstall_runner_action.cc	View	1 2	2 chunks	+47 lines, -39 lines	0 comments	Download
M	postinstall_runner_action_unittest.cc	View		4 chunks	+23 lines, -4 lines	0 comments	Download
M	subprocess.h	View	1 2 3	5 chunks	+38 lines, -21 lines	0 comments	Download
M	subprocess.cc	View		3 chunks	+80 lines, -27 lines	0 comments	Download
M	subprocess_unittest.cc	View		2 chunks	+26 lines, -2 lines	0 comments	Download
M	utils.h	View		3 chunks	+33 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

LGTM w/ nit http://codereview.chromium.org/4690006/diff/4001/subprocess.h File subprocess.h (right): http://codereview.chromium.org/4690006/diff/4001/subprocess.h#newcode96 subprocess.h:96: std::map<int, std::tr1::shared_ptr<SubprocessRecord> > subprocess_records_; comment about ...

10 years, 1 month ago (2010-11-10 22:15:38 UTC) #2

petkov

10 years, 1 month ago (2010-11-10 22:22:49 UTC) #3

Pushing...

http://codereview.chromium.org/4690006/diff/4001/subprocess.h
File subprocess.h (right):

http://codereview.chromium.org/4690006/diff/4001/subprocess.h#newcode96
subprocess.h:96: std::map<int, std::tr1::shared_ptr<SubprocessRecord> >
subprocess_records_;
On 2010/11/10 22:15:38, adlr wrote:
> comment about what the int is?

Done.

Expand Messages | Collapse Messages