Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: postinstall_runner_action.h

Issue 4690006: AU: Execute postinst asynchronously so that the D-Bus service is not blocked. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/update_engine.git@master
Patch Set: address review comments Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | postinstall_runner_action.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: postinstall_runner_action.h
diff --git a/postinstall_runner_action.h b/postinstall_runner_action.h
index c2498e0e1c67a47d087cbba5ba9135ece4637fbb..9a2ebcb697d12c4bbea877f0af1aa3d5ed106185 100644
--- a/postinstall_runner_action.h
+++ b/postinstall_runner_action.h
@@ -6,6 +6,7 @@
#define CHROMEOS_PLATFORM_UPDATE_ENGINE_POSTINSTALL_RUNNER_ACTION_H__
#include <string>
+
#include "update_engine/action.h"
#include "update_engine/install_plan.h"
@@ -35,8 +36,7 @@ class PostinstallRunnerAction : public Action<PostinstallRunnerAction> {
OutputObjectType;
void PerformAction();
- // This is a synchronous action, and thus TerminateProcessing() should
- // never be called
+ // Note that there's no support for terminating this action currently.
void TerminateProcessing() { CHECK(false); }
// Debugging/logging
@@ -44,6 +44,14 @@ class PostinstallRunnerAction : public Action<PostinstallRunnerAction> {
std::string Type() const { return StaticType(); }
private:
+ // Subprocess::Exec callback.
+ void CompletePostinstall(int return_code);
+ static void StaticCompletePostinstall(int return_code,
+ const std::string& output,
+ void* p);
+
+ std::string temp_rootfs_dir_;
+
DISALLOW_COPY_AND_ASSIGN(PostinstallRunnerAction);
};
« no previous file with comments | « no previous file | postinstall_runner_action.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698