Issue 4687009: Fixes possible crash in TabStripModel. If during close all a tab was

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4687009: Fixes possible crash in TabStripModel. If during close all a tab was (Closed)

Created:
10 years, 1 month ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fixes possible crash in TabStripModel. If during close all a tab was removed out from under the TabStripModel it would still attempt to remove the tab. At least this is my best guess as to what is causing the crash. BUG=34135 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65872

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -4 lines)			Patch
	M	chrome/browser/tabs/tab_strip_model.cc	View		3 chunks	+18 lines, -4 lines	1 comment	Download
	M	chrome/browser/tabs/tab_strip_model_unittest.cc	View	1	2 chunks	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

10 years, 1 month ago (2010-11-11 22:20:27 UTC) #2

OK

http://codereview.chromium.org/4687009/diff/2001/chrome/browser/tabs/tab_stri...
File chrome/browser/tabs/tab_strip_model.cc (right):

http://codereview.chromium.org/4687009/diff/2001/chrome/browser/tabs/tab_stri...
chrome/browser/tabs/tab_strip_model.cc:798: // tabs we're ok.
Can you mention what situations would cause one tab to delete another?

Expand Messages | Collapse Messages