Fixes possible crash in TabStripModel. If during close all a tab was

chrome/browser/tabs/tab_strip_model_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "app/system_monitor.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/string_number_conversions.h"
 #include "base/scoped_ptr.h"
@@ skipping 18 matching lines @@
 #include "chrome/common/notification_registrar.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/property_bag.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/testing_profile.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using testing::_;
 
+namespace {
+
+// Class used to delete a TabContents when another TabContents is destroyed.
+class DeleteTabContentsOnDestroyedObserver : public NotificationObserver {
+ public:
+  DeleteTabContentsOnDestroyedObserver(TabContents* source,
+                                       TabContents* tab_to_delete)
+      : source_(source),
+        tab_to_delete_(tab_to_delete) {
+    registrar_.Add(this,
+                   NotificationType::TAB_CONTENTS_DESTROYED,
+                   Source<TabContents>(source));
+  }
+
+  virtual void Observe(NotificationType type,
+                       const NotificationSource& source,
+                       const NotificationDetails& details) {
+    TabContents* tab_to_delete = tab_to_delete_;
+    tab_to_delete_ = NULL;
+    delete tab_to_delete;
+  }
+
+ private:
+  TabContents* source_;
+  TabContents* tab_to_delete_;
+  NotificationRegistrar registrar_;
+
+  DISALLOW_COPY_AND_ASSIGN(DeleteTabContentsOnDestroyedObserver);
+};
+
+}  // namespace
+
 class TabStripDummyDelegate : public TabStripModelDelegate {
  public:
   explicit TabStripDummyDelegate(TabContents* dummy)
       : dummy_contents_(dummy), can_close_(true), run_unload_(false) {}
   virtual ~TabStripDummyDelegate() {}
 
   void set_can_close(bool value) { can_close_ = value; }
   void set_run_unload_listener(bool value) { run_unload_ = value; }
 
   // Overridden from TabStripModelDelegate:
@@ skipping 1779 matching lines @@
   strip.ReplaceTabContentsAt(1, new_contents);
 
   ASSERT_EQ(1, tabstrip_observer.GetStateCount());
 
   state = State(new_contents, 1, MockTabStripModelObserver::REPLACED);
   state.src_contents = third_contents;
   EXPECT_TRUE(tabstrip_observer.StateEquals(0, state));
 
   strip.CloseAllTabs();
 }
+
+// Makes sure TabStripModel handles the case of deleting a tab while removing
+// another tab.
+TEST_F(TabStripModelTest, DeleteFromDestroy) {
+  TabStripDummyDelegate delegate(NULL);
+  TabStripModel strip(&delegate, profile());
+  TabContents* contents1 = CreateTabContents();
+  TabContents* contents2 = CreateTabContents();
+  strip.AppendTabContents(contents1, true);
+  strip.AppendTabContents(contents2, true);
+  // DeleteTabContentsOnDestroyedObserver deletes contents1 when contents2 sends
+  // out notification that it is being destroyed.
+  DeleteTabContentsOnDestroyedObserver observer(contents2, contents1);
+  strip.CloseAllTabs();
+}