Track permissions granted to extensions in prefs

chrome/common/extensions/extension_manifests_unittest.cc

Index: chrome/common/extensions/extension_manifests_unittest.cc
diff --git a/chrome/common/extensions/extension_manifests_unittest.cc b/chrome/common/extensions/extension_manifests_unittest.cc
index 3a891666537cc2a88269429db57fb0fea32272c3..e2a9f4531d8b5cb5af4a2eba794683bb53b7ad41 100644
--- a/chrome/common/extensions/extension_manifests_unittest.cc
+++ b/chrome/common/extensions/extension_manifests_unittest.cc
@@ -308,13 +308,11 @@ TEST_F(ExtensionManifestTest, DisallowExtensionPermissions) {
     permissions->Clear();
     permissions->Append(p);
     std::string message_name = base::StringPrintf("permission-%s", name);
-    if (Extension::IsHostedAppPermission(name)) {
-      scoped_refptr<Extension> extension;
-      extension = LoadAndExpectSuccess(manifest.get(), message_name);
-    } else {
-      LoadAndExpectError(manifest.get(), message_name,
-                         errors::kInvalidPermission);
-    }
+
+    // Since we no longer throw errors when permissions aren't recognized,
+    // the extension should successfully load for any of these.

[Aaron Boodman, 2010/11/12 00:05:24]

This comment seems kinda cryptic. How about renaming the test so that it's like
"AllowUnrecognizedPermissions" or something?

Also, do we have a test that handles the case of invalid URLPatterns in host
permissions?

[jstritar, 2010/11/19 21:38:36]

I renamed the test and updated the comment.

As for testing invalid URLPatterns, ChromeURLPermissionInvalid checks for an
error when using the "chrome://newtab/" permission and
ChromeURLContentScriptInvalid tests a similar case for the content_script
matches field. I don't think we can test beyond valid schemes, since we assume
they're unrecognized API permissions when they fail parsing. We could probably
improve error handling by validating the API permissions, by for instance,
assuming it's a URLPattern if it contains one of these chars ".:/". I don't do
this right now though.

+    scoped_refptr<Extension> extension;
+    extension = LoadAndExpectSuccess(manifest.get(), message_name);
   }
 }