Track permissions granted to extensions in prefs

chrome/common/extensions/extension_extent.cc

Index: chrome/common/extensions/extension_extent.cc
diff --git a/chrome/common/extensions/extension_extent.cc b/chrome/common/extensions/extension_extent.cc
index 5b8260af2a290ea3ee790caebdbff590430cc5ae..8a67bbfe5895b90b25b56c9252036691624c7ea9 100644
--- a/chrome/common/extensions/extension_extent.cc
+++ b/chrome/common/extensions/extension_extent.cc
@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/logging.h"
 #include "chrome/common/extensions/extension_extent.h"
 
 #include "chrome/common/extensions/url_pattern.h"
@@ -58,3 +59,12 @@ bool ExtensionExtent::OverlapsWith(const ExtensionExtent& other) const {
 
   return false;
 }
+
+void ExtensionExtent::GetAsStringSet(

[Aaron Boodman, 2010/11/12 00:05:24]

It seems ugly somehow to pass these around as string sets. Can you push the
details of serializing ExtensionExtents to strings and parsing ExtensionExtents
from strings out to the edges more? I would like to see ExtensionExtent being
passed, eg, to Extension::IsPermissionIncrease(), rather than
std::set<std::string>

Only ExtensionPrefs should have methods that accept and return ExtensionExtents
and it should deal with the parsing internally.

[jstritar, 2010/11/19 21:38:36]

Done. I now have an "AddPattern" helper method in a few different files
(extension_prefs.cc, extension_service_unittest.cc and
extension_prefs_unittest.cc). Is there a good place to put this or should I
leave it copy+pasted?

+    std::set<std::string>* string_patterns) const {
+  DCHECK(string_patterns);
+
+  for (PatternList::const_iterator i = patterns().begin();
+       i != patterns().end(); ++i)
+    string_patterns->insert(i->GetAsString());
+}