Issue 4678007: Fix compile error on Windows (no snprintf support).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4678007: Fix compile error on Windows (no snprintf support). (Closed)

Created:
10 years, 1 month ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Visibility:
Public.

Description

Fix compile error on Windows (no snprintf support). Luckily the snprintf wasn't really needed. TBR:whesse

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
	M	test/cctest/test-parsing.cc	View		1 chunk	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

LGTM. Why was the string so long before, if it wasn't necessary?

10 years, 1 month ago (2010-11-11 13:52:10 UTC) #2

Lasse Reichstein

10 years, 1 month ago (2010-11-11 14:07:44 UTC) #3

Just a change of mind in the middle of writing it. To begin with, I thought I'd
need a big string to trigger preparsing before parsing, but I only really needed
the preparsing, so I could call that directly.

Expand Messages | Collapse Messages