Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Side by Side Diff: test/cctest/test-parsing.cc

Issue 4678007: Fix compile error on Windows (no snprintf support). (Closed)
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 CHECK(!data.has_error()); 271 CHECK(!data.has_error());
272 } 272 }
273 } 273 }
274 274
275 275
276 TEST(RegressChromium62639) { 276 TEST(RegressChromium62639) {
277 int marker; 277 int marker;
278 i::StackGuard::SetStackLimit( 278 i::StackGuard::SetStackLimit(
279 reinterpret_cast<uintptr_t>(&marker) - 128 * 1024); 279 reinterpret_cast<uintptr_t>(&marker) - 128 * 1024);
280 280
281 char buffer[4096]; 281 const char* program = "var x = 'something';\n"
282 const char* program_template = "var x = '%01024d'; // filler\n" 282 "escape: function() {}";
283 "escape: function() {}";
284 // Fails parsing expecting an identifier after "function". 283 // Fails parsing expecting an identifier after "function".
285 // Before fix, didn't check *ok after Expect(Token::Identifier, ok), 284 // Before fix, didn't check *ok after Expect(Token::Identifier, ok),
286 // and then used the invalid currently scanned literal. This always 285 // and then used the invalid currently scanned literal. This always
287 // failed in debug mode, and sometimes crashed in release mode. 286 // failed in debug mode, and sometimes crashed in release mode.
288 287
289 snprintf(buffer, sizeof(buffer), program_template, 0); 288 unibrow::Utf8InputBuffer<256> stream(program, strlen(program));
290 unibrow::Utf8InputBuffer<256> stream(buffer, strlen(buffer));
291 i::ScriptDataImpl* data = 289 i::ScriptDataImpl* data =
292 i::ParserApi::PreParse(i::Handle<i::String>::null(), &stream, NULL); 290 i::ParserApi::PreParse(i::Handle<i::String>::null(), &stream, NULL);
293 CHECK(data->HasError()); 291 CHECK(data->HasError());
294 delete data; 292 delete data;
295 } 293 }
296 294
297 295
298 TEST(Regress928) { 296 TEST(Regress928) {
299 // Preparsing didn't consider the catch clause of a try statement 297 // Preparsing didn't consider the catch clause of a try statement
300 // as with-content, which made it assume that a function inside 298 // as with-content, which made it assume that a function inside
(...skipping 22 matching lines...) Expand all
323 CHECK(!entry1.is_valid()); 321 CHECK(!entry1.is_valid());
324 322
325 int second_function = strstr(program + first_lbrace, "function") - program; 323 int second_function = strstr(program + first_lbrace, "function") - program;
326 int second_lbrace = second_function + strlen("function () "); 324 int second_lbrace = second_function + strlen("function () ");
327 CHECK_EQ('{', program[second_lbrace]); 325 CHECK_EQ('{', program[second_lbrace]);
328 i::FunctionEntry entry2 = data->GetFunctionEntry(second_lbrace); 326 i::FunctionEntry entry2 = data->GetFunctionEntry(second_lbrace);
329 CHECK(entry2.is_valid()); 327 CHECK(entry2.is_valid());
330 CHECK_EQ('}', program[entry2.end_pos() - 1]); 328 CHECK_EQ('}', program[entry2.end_pos() - 1]);
331 delete data; 329 delete data;
332 } 330 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698