Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: ppapi/proxy/ppp_instance_proxy.cc

Issue 4659001: Convert Chrome PPAPI proxy from bool to PP_Bool. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/ppp_instance_proxy.cc
===================================================================
--- ppapi/proxy/ppp_instance_proxy.cc (revision 65343)
+++ ppapi/proxy/ppp_instance_proxy.cc (working copy)
@@ -17,10 +17,10 @@
namespace {
-bool DidCreate(PP_Instance instance,
- uint32_t argc,
- const char* argn[],
- const char* argv[]) {
+PP_Bool DidCreate(PP_Instance instance,
+ uint32_t argc,
+ const char* argn[],
+ const char* argv[]) {
std::vector<std::string> argn_vect;
std::vector<std::string> argv_vect;
for (uint32_t i = 0; i < argc; i++) {
@@ -28,7 +28,7 @@
argv_vect.push_back(std::string(argv[i]));
}
- bool result = false;
+ PP_Bool result = PP_FALSE;
HostDispatcher::GetForInstance(instance)->Send(
new PpapiMsg_PPPInstance_DidCreate(INTERFACE_ID_PPP_INSTANCE, instance,
argn_vect, argv_vect, &result));
@@ -48,24 +48,24 @@
instance, *position, *clip));
}
-void DidChangeFocus(PP_Instance instance, bool has_focus) {
+void DidChangeFocus(PP_Instance instance, PP_Bool has_focus) {
HostDispatcher::GetForInstance(instance)->Send(
new PpapiMsg_PPPInstance_DidChangeFocus(INTERFACE_ID_PPP_INSTANCE,
instance, has_focus));
}
-bool HandleInputEvent(PP_Instance instance,
- const PP_InputEvent* event) {
- bool result = false;
+PP_Bool HandleInputEvent(PP_Instance instance,
+ const PP_InputEvent* event) {
+ PP_Bool result = PP_FALSE;
HostDispatcher::GetForInstance(instance)->Send(
new PpapiMsg_PPPInstance_HandleInputEvent(INTERFACE_ID_PPP_INSTANCE,
instance, *event, &result));
return result;
}
-bool HandleDocumentLoad(PP_Instance instance,
- PP_Resource url_loader) {
- bool result = false;
+PP_Bool HandleDocumentLoad(PP_Instance instance,
+ PP_Resource url_loader) {
+ PP_Bool result = PP_FALSE;
HostDispatcher::GetForInstance(instance)->Send(
new PpapiMsg_PPPInstance_HandleDocumentLoad(INTERFACE_ID_PPP_INSTANCE,
instance, url_loader,
@@ -132,8 +132,8 @@
PP_Instance instance,
const std::vector<std::string>& argn,
const std::vector<std::string>& argv,
- bool* result) {
- *result = false;
+ PP_Bool* result) {
+ *result = PP_FALSE;
if (argn.size() != argv.size())
return;
@@ -141,7 +141,7 @@
// address below.
std::vector<const char*> argn_array(
std::max(static_cast<size_t>(1), argn.size()));
- std::vector<const char*> argv_array;
+ std::vector<const char*> argv_array(
std::max(static_cast<size_t>(1), argn.size()));
for (size_t i = 0; i < argn.size(); i++) {
argn_array[i] = argn[i].c_str();
@@ -166,19 +166,19 @@
}
void PPP_Instance_Proxy::OnMsgDidChangeFocus(PP_Instance instance,
- bool has_focus) {
+ PP_Bool has_focus) {
ppp_instance_target()->DidChangeFocus(instance, has_focus);
}
void PPP_Instance_Proxy::OnMsgHandleInputEvent(PP_Instance instance,
const PP_InputEvent& event,
- bool* result) {
+ PP_Bool* result) {
*result = ppp_instance_target()->HandleInputEvent(instance, &event);
}
void PPP_Instance_Proxy::OnMsgHandleDocumentLoad(PP_Instance instance,
PP_Resource url_loader,
- bool* result) {
+ PP_Bool* result) {
PPB_URLLoader_Proxy::TrackPluginResource(url_loader);
*result = ppp_instance_target()->HandleDocumentLoad(
instance, url_loader);

Powered by Google App Engine
This is Rietveld 408576698