Convert Chrome PPAPI proxy from bool to PP_Bool.

ppapi/proxy/serialized_var.cc

Index: ppapi/proxy/serialized_var.cc
===================================================================
--- ppapi/proxy/serialized_var.cc	(revision 65343)
+++ ppapi/proxy/serialized_var.cc	(working copy)
@@ -7,6 +7,7 @@
 #include "base/logging.h"
 #include "ipc/ipc_message_utils.h"
 #include "ppapi/proxy/dispatcher.h"
+#include "ppapi/proxy/interface_proxy.h"
 #include "ppapi/proxy/ppapi_param_traits.h"
 #include "ppapi/proxy/var_serialization_rules.h"
 
@@ -171,9 +172,12 @@
       // just serialized.
       success = true;
       break;
-    case PP_VARTYPE_BOOL:
-      success = m->ReadBool(iter, &var_.value.as_bool);
+    case PP_VARTYPE_BOOL: {
+      bool bool_value;
+      success = m->ReadBool(iter, &bool_value);

[dmichael(do not use this one), 2010/11/08 15:31:19]

Maybe this would be premature optimization, but you could just serialize the
PP_Bool with a cast and WriteInt.  That's what happens to the bool value anyway,
so the current code converts enum->bool->int for serialization, and
int->bool->enum for deserialization.

[brettw, 2010/11/08 15:51:02]

The plugin might be malicious or have a bug and write a non-PP_TRUE/FALSE value
like "2". I prefer to get a correct bool value out at the renderer side to avoid
bugs. This current code will "fix" the problem when serializing, and if it's
invalid when deserializing, will report an error. Probably eventually the
deserializing error will cause us to kill the plugins since it's sending us
incorrect messages (we do this with renderers).

[dmichael(do not use this one), 2010/11/08 16:11:51]

Good point.  May warrant a comment, then, to fend off future thoughts of
inappropriate optimization?

+      var_.value.as_bool = BoolToPPBool(bool_value);
       break;
+    }
     case PP_VARTYPE_INT32:
       success = m->ReadInt(iter, &var_.value.as_int);
       break;