Open apps section on NTP when new app get installed

Open apps section on NTP when new app get installed

BUG=http://code.google.com/p/chromium-os/issues/detail?id=8323
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65917

[Aaron Boodman, 2010-11-11 17:59:12]

Ah, good change. Yes, if the NTP is not open when an app is installed then the
apps section won't get set to shown. Makes sense.

LGTM w/ the below nits. No need to wait for another lg from me unless you have
questions.

http://codereview.chromium.org/4658006/diff/1/chrome/browser/dom_ui/shown_sec...
File chrome/browser/dom_ui/shown_sections_handler.cc (left):

http://codereview.chromium.org/4658006/diff/1/chrome/browser/dom_ui/shown_sec...
chrome/browser/dom_ui/shown_sections_handler.cc:58:
notification_registrar_.Add(this, NotificationType::EXTENSION_INSTALLED,
Looks like this member is no longer used. Can you remove it, and the
notification_registrar.h header?

http://codereview.chromium.org/4658006/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_prefs.cc (right):

http://codereview.chromium.org/4658006/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_prefs.cc:542:
ShownSectionsHandler::OnExtensionInstalled(prefs_, extension);
We usually do this kind of work in ExtensionsService, not ExtensionPrefs, in the
OnInstalled method there. Can you move the code there?

[Dmitry Polukhin, 2010-11-11 20:08:19]

http://codereview.chromium.org/4658006/diff/1/chrome/browser/dom_ui/shown_sec...
File chrome/browser/dom_ui/shown_sections_handler.cc (left):

http://codereview.chromium.org/4658006/diff/1/chrome/browser/dom_ui/shown_sec...
chrome/browser/dom_ui/shown_sections_handler.cc:58:
notification_registrar_.Add(this, NotificationType::EXTENSION_INSTALLED,
On 2010/11/11 17:59:13, Aaron Boodman wrote:
> Looks like this member is no longer used. Can you remove it, and the
> notification_registrar.h header?

Done.

http://codereview.chromium.org/4658006/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_prefs.cc (right):

http://codereview.chromium.org/4658006/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_prefs.cc:542:
ShownSectionsHandler::OnExtensionInstalled(prefs_, extension);
On 2010/11/11 17:59:13, Aaron Boodman wrote:
> We usually do this kind of work in ExtensionsService, not ExtensionPrefs, in
the
> OnInstalled method there. Can you move the code there?

Done.

[Aaron Boodman, 2010-11-11 21:18:35]

Still lg, thanks.