Open apps section on NTP when new app get installed

chrome/browser/dom_ui/shown_sections_handler.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/dom_ui/shown_sections_handler.h"
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/string_number_conversions.h"
 #include "base/values.h"
@@ skipping 37 matching lines @@
   return prefs->GetInteger(prefs::kNTPShownSections);
 }
 
 ShownSectionsHandler::ShownSectionsHandler(PrefService* pref_service)
     : pref_service_(pref_service) {
   pref_registrar_.Init(pref_service);
   pref_registrar_.Add(prefs::kNTPShownSections, this);
 }
 
 void ShownSectionsHandler::RegisterMessages() {
-  notification_registrar_.Add(this, NotificationType::EXTENSION_INSTALLED,

[Aaron Boodman, 2010/11/11 17:59:13]

Looks like this member is no longer used. Can you remove it, and the
notification_registrar.h header?

[Dmitry Polukhin, 2010/11/11 20:08:20]

Done.

-                              Source<Profile>(dom_ui_->GetProfile()));
-
   dom_ui_->RegisterMessageCallback("getShownSections",
       NewCallback(this, &ShownSectionsHandler::HandleGetShownSections));
   dom_ui_->RegisterMessageCallback("setShownSections",
       NewCallback(this, &ShownSectionsHandler::HandleSetShownSections));
 }
 
 void ShownSectionsHandler::Observe(NotificationType type,
                                    const NotificationSource& source,
                                    const NotificationDetails& details) {
   if (type == NotificationType::PREF_CHANGED) {
     std::string* pref_name = Details<std::string>(details).ptr();
     DCHECK(*pref_name == prefs::kNTPShownSections);
     int sections = pref_service_->GetInteger(prefs::kNTPShownSections);
     FundamentalValue sections_value(sections);
     dom_ui_->CallJavascriptFunction(L"setShownSections", sections_value);
-  } else if (type == NotificationType::EXTENSION_INSTALLED) {
-    if (Details<const Extension>(details).ptr()->is_app()) {
-      int mode = pref_service_->GetInteger(prefs::kNTPShownSections);
-
-      // De-minimize the apps section.
-      mode &= ~MINIMIZED_APPS;
-
-      // Hide any open sections.
-      mode &= ~ALL_SECTIONS_MASK;
-
-      // Show the apps section.
-      mode |= APPS;
-
-      pref_service_->SetInteger(prefs::kNTPShownSections, mode);
-    }
   } else {
     NOTREACHED();
   }
 }
 
 void ShownSectionsHandler::HandleGetShownSections(const ListValue* args) {
   int sections = GetShownSections(pref_service_);
   FundamentalValue sections_value(sections);
   dom_ui_->CallJavascriptFunction(L"onShownSections", sections_value);
 }
@@ skipping 29 matching lines @@
       shown_sections = APPS;
     else
       shown_sections = THUMB;
 
     changed = true;
   }
 
   if (changed)
     pref_service->SetInteger(prefs::kNTPShownSections, shown_sections);
 }
+
+// static
+void ShownSectionsHandler::OnExtensionInstalled(PrefService* prefs,
+                                                const Extension* extension) {
+  if (extension->is_app()) {
+    int mode = prefs->GetInteger(prefs::kNTPShownSections);
+
+    // De-minimize the apps section.
+    mode &= ~MINIMIZED_APPS;
+
+    // Hide any open sections.
+    mode &= ~ALL_SECTIONS_MASK;
+
+    // Show the apps section.
+    mode |= APPS;
+
+    prefs->SetInteger(prefs::kNTPShownSections, mode);
+  }
+}