Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: media/tools/player_x11/player_x11.cc

Issue 4653005: Move FilterType into MediaFilterCollection (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Implemented CR suggestions Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/decoder_base_unittest.cc ('k') | webkit/glue/webmediaplayer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/tools/player_x11/player_x11.cc
diff --git a/media/tools/player_x11/player_x11.cc b/media/tools/player_x11/player_x11.cc
index ad307c4891ef0ac3aae17e9fed35b4e0a278a315..ffff1bd92848a034b0d846379c15e5919ef79f66 100644
--- a/media/tools/player_x11/player_x11.cc
+++ b/media/tools/player_x11/player_x11.cc
@@ -99,21 +99,23 @@ bool InitPipeline(MessageLoop* message_loop,
// Create our filter factories.
scoped_ptr<media::MediaFilterCollection> collection(
new media::MediaFilterCollection());
- collection->AddFilter(new media::FileDataSource());
- collection->AddFilter(new media::FFmpegDemuxer());
- collection->AddFilter(new media::FFmpegAudioDecoder());
+ collection->AddDataSource(new media::FileDataSource());
scherkus (not reviewing) 2010/11/11 19:33:35 wow this code reads much nicer :)
+ collection->AddDemuxer(new media::FFmpegDemuxer());
+ collection->AddAudioDecoder(new media::FFmpegAudioDecoder());
if (CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableOpenMax)) {
- collection->AddFilter(new media::OmxVideoDecoder(NULL));
+ collection->AddVideoDecoder(new media::OmxVideoDecoder(NULL));
} else {
- collection->AddFilter(new media::FFmpegVideoDecoder(NULL));
+ collection->AddVideoDecoder(new media::FFmpegVideoDecoder(NULL));
}
- collection->AddFilter(new Renderer(g_display, g_window, paint_message_loop));
+ collection->AddVideoRenderer(new Renderer(g_display,
+ g_window,
+ paint_message_loop));
if (enable_audio)
- collection->AddFilter(new media::AudioRendererImpl());
+ collection->AddAudioRenderer(new media::AudioRendererImpl());
else
- collection->AddFilter(new media::NullAudioRenderer());
+ collection->AddAudioRenderer(new media::NullAudioRenderer());
// Creates the pipeline and start it.
*pipeline = new media::PipelineImpl(message_loop);
« no previous file with comments | « media/filters/decoder_base_unittest.cc ('k') | webkit/glue/webmediaplayer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698