Move FilterType into MediaFilterCollection

media/tools/player_x11/player_x11.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <iostream>
 #include <signal.h>
 #include <X11/keysym.h>
 #include <X11/Xlib.h>
 
 #include "base/at_exit.h"
@@ skipping 81 matching lines @@
 
   // Load media libraries.
   if (!media::InitializeMediaLibrary(FilePath())) {
     std::cout << "Unable to initialize the media library." << std::endl;
     return false;
   }
 
   // Create our filter factories.
   scoped_ptr<media::MediaFilterCollection> collection(
       new media::MediaFilterCollection());
-  collection->AddFilter(new media::FileDataSource());
-  collection->AddFilter(new media::FFmpegDemuxer());
-  collection->AddFilter(new media::FFmpegAudioDecoder());
+  collection->AddDataSource(new media::FileDataSource());

[scherkus (not reviewing), 2010/11/11 19:33:35]

wow this code reads much nicer :)

+  collection->AddDemuxer(new media::FFmpegDemuxer());
+  collection->AddAudioDecoder(new media::FFmpegAudioDecoder());
   if (CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnableOpenMax)) {
-    collection->AddFilter(new media::OmxVideoDecoder(NULL));
+    collection->AddVideoDecoder(new media::OmxVideoDecoder(NULL));
   } else {
-    collection->AddFilter(new media::FFmpegVideoDecoder(NULL));
+    collection->AddVideoDecoder(new media::FFmpegVideoDecoder(NULL));
   }
-  collection->AddFilter(new Renderer(g_display, g_window, paint_message_loop));
+  collection->AddVideoRenderer(new Renderer(g_display,
+                                            g_window,
+                                            paint_message_loop));
 
   if (enable_audio)
-    collection->AddFilter(new media::AudioRendererImpl());
+    collection->AddAudioRenderer(new media::AudioRendererImpl());
   else
-    collection->AddFilter(new media::NullAudioRenderer());
+    collection->AddAudioRenderer(new media::NullAudioRenderer());
 
   // Creates the pipeline and start it.
   *pipeline = new media::PipelineImpl(message_loop);
   (*pipeline)->Start(collection.release(), filename, NULL);
 
   // Wait until the pipeline is fully initialized.
   while (true) {
     PlatformThread::Sleep(100);
     if ((*pipeline)->IsInitialized())
       break;
@@ skipping 133 matching lines @@
   } else{
     std::cout << "Pipeline initialization failed..." << std::endl;
   }
 
   // Cleanup tasks.
   thread->Stop();
   XDestroyWindow(g_display, g_window);
   XCloseDisplay(g_display);
   return 0;
 }