Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 465128: Add breakpad support to git-try and trychange.py (Closed)

Created:
11 years ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add breakpad support to git-try and trychange.py

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M git-try View 1 chunk +6 lines, -2 lines 0 comments Download
M trychange.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
11 years ago (2009-12-08 21:19:36 UTC) #1
bradn
Wow, that's easier to add then I'd have thought. LGTM
11 years ago (2009-12-08 21:22:17 UTC) #2
bradn
Doesn't it need some sort of app id?
11 years ago (2009-12-08 21:22:31 UTC) #3
M-A Ruel
On 2009/12/08 21:22:31, bradn wrote: > Doesn't it need some sort of app id? No. ...
11 years ago (2009-12-08 21:24:52 UTC) #4
bradn
11 years ago (2009-12-08 21:25:45 UTC) #5
Oh sweet.

LGTM

On Tue, Dec 8, 2009 at 1:24 PM, <maruel@chromium.org> wrote:

> On 2009/12/08 21:22:31, bradn wrote:
>
>> Doesn't it need some sort of app id?
>>
>
> No. It sends sys.argv which is plenty.
>
>
> http://codereview.chromium.org/465128
>

Powered by Google App Engine
This is Rietveld 408576698