Fix navigation bugs, patch the right file, nuke an old file.

chrome/browser/ui/browser_navigator.h

Index: chrome/browser/ui/browser_navigator.h
diff --git a/chrome/browser/ui/browser_navigator.h b/chrome/browser/ui/browser_navigator.h
index aee08db4f4a86bc345a0f58db4d9ab7d394874e5..08f9c03384fce35c646eca5cd468b2fccacac61f 100644
--- a/chrome/browser/ui/browser_navigator.h
+++ b/chrome/browser/ui/browser_navigator.h
@@ -80,10 +80,12 @@ struct NavigateParams {
   // CURRENT_TAB          "     "     "                     NEW_FOREGROUND_TAB
   // OFF_THE_RECORD       target browser profile is incog.  NEW_FOREGROUND_TAB
   //
-  // If disposition is NEW_WINDOW or NEW_POPUP, |show_window| is set to true
-  // automatically.
   // If disposition is NEW_BACKGROUND_TAB, TabStripModel::ADD_SELECTED is
   // removed from |tabstrip_add_types| automatically.
+  // If disposition is one of NEW_WINDOW, NEW_POPUP, NEW_FOREGROUND_TAB or

[Ben Goodger (Google), 2010/11/17 15:57:50]

The list of dispositions here now that coerce show_window no longer match that
in the switch statement in the .cc file.

Also you should explain next to show_window the conditions that lead to its
coercion.

[sadrul, 2010/11/17 17:02:23]

Done.

+  // SINGLETON_TAB, then |show_window| is set to true and
+  // TabStripModel::ADD_SELECTED is automatically added to
+  // |tabstrip_add_types|.
   WindowOpenDisposition disposition;
 
   // The transition type of the navigation. Default is PageTransition::LINK