Fix navigation bugs, patch the right file, nuke an old file.

chrome/browser/ui/browser_navigator.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_NAVIGATOR_H_
 #define CHROME_BROWSER_UI_BROWSER_NAVIGATOR_H_
 #pragma once
 
 #include <string>
 
@@ skipping 62 matching lines @@
 
   // The disposition requested by the navigation source. Default is
   // CURRENT_TAB. What follows is a set of coercions that happen to this value
   // when other factors are at play:
   //
   // [in]:                Condition:                        [out]:
   // NEW_BACKGROUND_TAB   target browser tabstrip is empty  NEW_FOREGROUND_TAB
   // CURRENT_TAB          "     "     "                     NEW_FOREGROUND_TAB
   // OFF_THE_RECORD       target browser profile is incog.  NEW_FOREGROUND_TAB
   //
-  // If disposition is NEW_WINDOW or NEW_POPUP, |show_window| is set to true
-  // automatically.
   // If disposition is NEW_BACKGROUND_TAB, TabStripModel::ADD_SELECTED is
   // removed from |tabstrip_add_types| automatically.
+  // If disposition is one of NEW_WINDOW, NEW_POPUP, NEW_FOREGROUND_TAB or

[Ben Goodger (Google), 2010/11/17 15:57:50]

The list of dispositions here now that coerce show_window no longer match that
in the switch statement in the .cc file.

Also you should explain next to show_window the conditions that lead to its
coercion.

[sadrul, 2010/11/17 17:02:23]

Done.

+  // SINGLETON_TAB, then |show_window| is set to true and
+  // TabStripModel::ADD_SELECTED is automatically added to
+  // |tabstrip_add_types|.
   WindowOpenDisposition disposition;
 
   // The transition type of the navigation. Default is PageTransition::LINK
   // when target_contents is specified in the constructor.
   PageTransition::Type transition;
 
   // The index the caller would like the tab to be positioned at in the
   // TabStrip. The actual index will be determined by the TabHandler in
   // accordance with |add_types|. Defaults to -1 (allows the TabHandler to
   // decide).
@@ skipping 40 matching lines @@
  private:
   NavigateParams();
 };
 
 // Navigates according to the configuration specified in |params|.
 void Navigate(NavigateParams* params);
 
 }  // namespace browser
 
 #endif  // CHROME_BROWSER_UI_BROWSER_NAVIGATOR_H_