Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 464078: Remove check for usage stats in the toast experiment... (Closed)

Created:
11 years ago by cpu_(ooo_6.6-7.5)
Modified:
9 years, 7 months ago
Reviewers:
Glenn Wilson, rahulk
CC:
chromium-reviews_googlegroups.com, kuchhal
Visibility:
Public.

Description

Remove check for usage stats in the toast experiment BUG=none TEST= same as before but you know don't need to opt-in for sending crash reports or usage stats TBR=rahulk Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34130

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/installer/util/google_chrome_distribution.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
cpu_(ooo_6.6-7.5)
11 years ago (2009-12-09 01:43:07 UTC) #1
Glenn Wilson
On 2009/12/09 01:43:07, cpu wrote: > lgtm
11 years ago (2009-12-09 16:12:10 UTC) #2
rahulk
11 years ago (2009-12-09 17:21:20 UTC) #3
lgtm.

On Tue, Dec 8, 2009 at 5:43 PM, <cpu@chromium.org> wrote:

> Reviewers: rahulk, gwilson,
>
> Description:
> Remove check for usage stats in the toast experiment
>
> BUG=none
> TEST= same as before but you know don't need to opt-in for sending crash
> reports
> or usage stats
>
> TBR=rahulk
>
>
>
> Please review this at http://codereview.chromium.org/464078
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/installer/util/google_chrome_distribution.cc
>
>
> Index: chrome/installer/util/google_chrome_distribution.cc
> ===================================================================
> --- chrome/installer/util/google_chrome_distribution.cc (revision 34119)
> +++ chrome/installer/util/google_chrome_distribution.cc (working copy)
> @@ -439,10 +439,6 @@
>   if ((installer_util::NEW_VERSION_UPDATED != status) || system_install)
>     return;
>
> -  // If user has not opted-in for usage stats  we don't do the
> experiments.
> -  if (!GoogleUpdateSettings::GetCollectStatsConsent())
> -    return;
> -
>   // currently only two equal experiment groups. 90% get the welcome back
> url.
>   int flavor = (base::RandDouble() > 0.1) ? 0 : 1;
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698