Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 464077: Fixes CFInstance to use a longer Deferred standard timeout. Short timeouts ca... (Closed)

Created:
11 years ago by slightlyoff
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, amit
Visibility:
Public.

Description

Fixes CFInstance to use a longer Deferred standard timeout. Short timeouts caused cancellation of listeners and therefore backlogged RPC callback failure. The API requires that we use a timeout, but upping the default to 10s should accomidate nearly all CF startup delays. BUG=None TEST=run all the CFInstance tests in a Debug build. TBR=ananta Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34116

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M chrome_frame/CFInstance.js View 4 chunks +8 lines, -13 lines 3 comments Download

Messages

Total messages: 3 (0 generated)
slightlyoff
11 years ago (2009-12-09 01:05:21 UTC) #1
ananta
LGTM http://codereview.chromium.org/464077/diff/1/2 File chrome_frame/CFInstance.js (left): http://codereview.chromium.org/464077/diff/1/2#oldcode1214 chrome_frame/CFInstance.js:1214: // RPC.prototype._doWithAck_load = function() { }; Remove? http://codereview.chromium.org/464077/diff/1/2#oldcode1221 ...
11 years ago (2009-12-09 01:08:28 UTC) #2
tommi (sloooow) - chröme
10 years, 10 months ago (2010-01-29 15:36:28 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698