Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5284)

Unified Diff: chrome_frame/CFInstance.js

Issue 464077: Fixes CFInstance to use a longer Deferred standard timeout. Short timeouts ca... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/CFInstance.js
===================================================================
--- chrome_frame/CFInstance.js (revision 34024)
+++ chrome_frame/CFInstance.js (working copy)
@@ -601,7 +601,7 @@
}
this._timer = setTimeout(
hitch(this, 'errback', new Error('timeout')),
- (timeout || 1000)
+ (timeout || 10000)
);
this.silentlyCancelled = false;
};
@@ -781,7 +781,7 @@
var fired = this.fired;
var res = this.results[fired];
var cb = null;
- while ((chain.length > 0) && (this.paused == 0)) {
+ while ((chain.length) && (!this.paused)) {
var f = chain.shift()[fired];
if (!f) {
continue;
@@ -1196,8 +1196,12 @@
RPC.prototype._postMessageBacklog = function() {
if (this._open) {
- forEach(this._msgBacklog, this._postMessage, this);
- this._msgBacklog = [];
+ // forEach(this._msgBacklog, this._postMessage, this);
+ // this._msgBacklog = [];
ananta 2009/12/09 01:08:28 Please delete these lines
+ while (this._msgBacklog.length) {
+ var msg = this._msgBacklog.shift();
+ this._postMessage(msg);
+ }
}
};
@@ -1210,16 +1214,7 @@
}
};
- // currently no-ops. We may need them in the future
- // RPC.prototype._doWithAck_load = function() { };
ananta 2009/12/09 01:08:28 Remove?
- // RPC.prototype._doWithAck_init = function() { };
-
RPC.prototype._doWithAck = function(what) {
- var f = this['_doWithAck_' + what];
- if (f) {
- f.call(this);
- }
ananta 2009/12/09 01:08:28 Ditto
-
this._postMessage('doWithAckCallback:' + what, what == 'load');
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698