Issue 462012: Add GURL-specific baseline for a layout test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 462012: Add GURL-specific baseline for a layout test. (Closed)

Created:
11 years ago by dglazkov

Modified:
9 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Add GURL-specific baseline for a layout test. R=brettw TEST=none BUG=27548 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33620

Patch Set 1 #

Patch Set 2 : Updated bug number. #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -6 lines)			Patch
A	webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt	View		1 chunk	+38 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt	View		1 chunk	+38 lines, -0 lines	0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View	1	2 chunks	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

11 years ago (2009-12-03 05:03:27 UTC) #3

LGTM

On Wed, Dec 2, 2009 at 3:20 PM,  <dglazkov@chromium.org> wrote:
> Reviewers: brettw,
>
> Description:
> Add GURL-specific baseline for a layout test.
>
> R=brettw
> TEST=none
> BUG=27548
>
>
> Please review this at http://codereview.chromium.org/462012
>
> SVN Base: svn://chrome-svn.corp.google.com/chrome/trunk/src/
>
> Affected files:
>  A
>
webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt
>  M     webkit/tools/layout_tests/test_expectations.txt
>
>
>

Expand Messages | Collapse Messages