Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: git-cl

Issue 461001: Add watchlist support to git-cl. (Closed)
Patch Set: new name Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « README.testing ('k') | test/basic.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git-cl
diff --git a/git-cl b/git-cl
index 0458f72406d15db04fe30de3541affc4e088aa20..cc66c197522e433e7eee96bd97bb7aa28e5b1571 100755
--- a/git-cl
+++ b/git-cl
@@ -51,7 +51,7 @@ def RunGit(args, **kwargs):
return RunCommand(cmd, **kwargs)
-class Settings:
+class Settings(object):
def __init__(self):
self.server = None
self.cc = None
@@ -73,8 +73,15 @@ class Settings:
return self.server
def GetCCList(self):
+ """Return the users cc'd on this CL.
+
+ Return is a string suitable for passing to gcl with the --cc flag.
+ """
if self.cc is None:
self.cc = self._GetConfig('rietveld.cc', error_ok=True)
+ more_cc = self._GetConfig('rietveld.extra_cc', error_ok=True)
Mandeep Singh Baines 2009/12/04 19:28:17 What is the use case for rietveld.extra_cc? I'm gu
+ if more_cc is not None:
+ self.cc += ',' + more_cc
return self.cc
def GetRoot(self):
@@ -195,7 +202,7 @@ def ShortBranchName(branch):
return branch.replace('refs/heads/', '')
-class Changelist:
+class Changelist(object):
def __init__(self, branchref=None):
# Poke settings so we get the "configure your server" message if necessary.
settings.GetServer()
« no previous file with comments | « README.testing ('k') | test/basic.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698